[libvirt] [PATCH] virsh: Clarify behavior of domain list filtering.
Some combinations of filtering flags produce no result. This patch tries to clarify this. Also fix unintentional double space. --- tools/virsh.pod | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index c6f205a..2efb277 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -395,10 +395,11 @@ into s3 state. Normally only active domains are listed. To list inactive domains specify I<--inactive> or I<--all> to list both active and inactive domains. -To filter the list of domains present on the hypervisor you may specify one or -more of filtering flags supported by the B<list> command. These flags are -grouped by function. Specifying one or more flags from a group enables the -filter group. Supported filtering flags and groups: +To further filter the list of domains you may specify one or more of filtering +flags supported by the B<list> command. These flags are grouped by function. +Specifying one or more flags from a group enables the filter group. Note that +some combinations of flags may yield no results. Supported filtering flags and +groups: =over 4 @@ -435,7 +436,7 @@ domains without a snapshot I<--without-snapshot>. When talking to older servers, this command is forced to use a series of API calls with an inherent race, where a domain might not be listed or might appear more than once if it changed state between calls while the list was being -collected. Newer servers do not have this problem. +collected. Newer servers do not have this problem. If I<--managed-save> is specified, then domains that have managed save state (only possible if they are in the B<shut off> state, so you need to specify -- 1.7.12
On 09/17/2012 03:02 AM, Peter Krempa wrote:
Some combinations of filtering flags produce no result. This patch tries to clarify this.
Also fix unintentional double space.
Actually, the double space is intentional - for years, it was typographical convention to separate all sentences by two spaces (although I will admit that modern style guides now list it as optional rather than mandatory).
--- tools/virsh.pod | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod index c6f205a..2efb277 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -395,10 +395,11 @@ into s3 state. Normally only active domains are listed. To list inactive domains specify I<--inactive> or I<--all> to list both active and inactive domains.
-To filter the list of domains present on the hypervisor you may specify one or -more of filtering flags supported by the B<list> command. These flags are -grouped by function. Specifying one or more flags from a group enables the -filter group. Supported filtering flags and groups: +To further filter the list of domains you may specify one or more of filtering +flags supported by the B<list> command. These flags are grouped by function. +Specifying one or more flags from a group enables the filter group. Note that +some combinations of flags may yield no results. Supported filtering flags and +groups:
ACK to this reword.
=over 4
@@ -435,7 +436,7 @@ domains without a snapshot I<--without-snapshot>. When talking to older servers, this command is forced to use a series of API calls with an inherent race, where a domain might not be listed or might appear more than once if it changed state between calls while the list was being -collected. Newer servers do not have this problem. +collected. Newer servers do not have this problem.
But NACK to this hunk, as it is just whitespace churn. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On 09/17/2012 05:02 AM, Peter Krempa wrote:
Some combinations of filtering flags produce no result. This patch tries to clarify this.
Also fix unintentional double space. --- tools/virsh.pod | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod index c6f205a..2efb277 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -395,10 +395,11 @@ into s3 state. Normally only active domains are listed. To list inactive domains specify I<--inactive> or I<--all> to list both active and inactive domains.
-To filter the list of domains present on the hypervisor you may specify one or -more of filtering flags supported by the B<list> command. These flags are -grouped by function. Specifying one or more flags from a group enables the -filter group. Supported filtering flags and groups: +To further filter the list of domains you may specify one or more of filtering
While you're here: s/more of filtering/more of the filtering/
+flags supported by the B<list> command. These flags are grouped by function. +Specifying one or more flags from a group enables the filter group. Note that +some combinations of flags may yield no results. Supported filtering flags and +groups:
=over 4
@@ -435,7 +436,7 @@ domains without a snapshot I<--without-snapshot>. When talking to older servers, this command is forced to use a series of API calls with an inherent race, where a domain might not be listed or might appear more than once if it changed state between calls while the list was being -collected. Newer servers do not have this problem. +collected. Newer servers do not have this problem.
If I<--managed-save> is specified, then domains that have managed save state (only possible if they are in the B<shut off> state, so you need to specify
ACK with that one small addition.
On 09/17/12 16:28, Laine Stump wrote:
On 09/17/2012 05:02 AM, Peter Krempa wrote:
Some combinations of filtering flags produce no result. This patch tries to clarify this.
Also fix unintentional double space. --- tools/virsh.pod | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod index c6f205a..2efb277 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -395,10 +395,11 @@ into s3 state. Normally only active domains are listed. To list inactive domains specify I<--inactive> or I<--all> to list both active and inactive domains.
-To filter the list of domains present on the hypervisor you may specify one or -more of filtering flags supported by the B<list> command. These flags are -grouped by function. Specifying one or more flags from a group enables the -filter group. Supported filtering flags and groups: +To further filter the list of domains you may specify one or more of filtering
While you're here: s/more of filtering/more of the filtering/
+flags supported by the B<list> command. These flags are grouped by function. +Specifying one or more flags from a group enables the filter group. Note that +some combinations of flags may yield no results. Supported filtering flags and +groups:
=over 4
ACK with that one small addition.
Bah, I just pushed it :(. I'll fix that in another patch. Peter
On 09/17/2012 10:40 AM, Peter Krempa wrote:
On 09/17/12 16:28, Laine Stump wrote:
On 09/17/2012 05:02 AM, Peter Krempa wrote:
Some combinations of filtering flags produce no result. This patch tries to clarify this.
Also fix unintentional double space. --- tools/virsh.pod | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod index c6f205a..2efb277 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -395,10 +395,11 @@ into s3 state. Normally only active domains are listed. To list inactive domains specify I<--inactive> or I<--all> to list both active and inactive domains.
-To filter the list of domains present on the hypervisor you may specify one or -more of filtering flags supported by the B<list> command. These flags are -grouped by function. Specifying one or more flags from a group enables the -filter group. Supported filtering flags and groups: +To further filter the list of domains you may specify one or more of filtering
While you're here: s/more of filtering/more of the filtering/
+flags supported by the B<list> command. These flags are grouped by function. +Specifying one or more flags from a group enables the filter group. Note that +some combinations of flags may yield no results. Supported filtering flags and +groups:
=over 4
ACK with that one small addition.
Bah, I just pushed it :(. I'll fix that in another patch.
Not a big deal - it's just one word, and it was there already :-)
participants (3)
-
Eric Blake -
Laine Stump -
Peter Krempa