[libvirt] [PATCH] Fix instructions on 'vnc_password' to describe current behaviour
This documentation change fixes the description of vnc_password in qemu.conf to fit the behaviour introduced in commit ab952024f42726a291d2c0ceda10071b88da7533 which treats a non-existent VNC password and an empty string password in the same way. Addresses https://bugzilla.redhat.com/show_bug.cgi?id=667097 diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index ba41f80..1a050fd 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -52,10 +52,8 @@ # The default VNC password. Only 8 letters are significant for # VNC passwords. This parameter is only used if the per-domain # XML config does not already provide a password. To allow -# access without passwords, leave this commented out. An empty -# string will still enable passwords, but be rejected by QEMU -# effectively preventing any use of VNC. Obviously change this -# example here before you set this +# access without passwords, either leave this commented out or use +# an empty string. Obviously change this example here before you set this. # # vnc_password = "XYZ12345"
On Fri, Jan 07, 2011 at 02:17:37PM +0000, Neil Wilson wrote:
This documentation change fixes the description of vnc_password in qemu.conf to fit the behaviour introduced in commit ab952024f42726a291d2c0ceda10071b88da7533 which treats a non-existent VNC password and an empty string password in the same way.
No this is not correct. If the password is set to "", then QEMU should be denying access when the ',password' flag is set on the command line. Daniel
On Fri, Jan 07, 2011 at 02:38:05PM +0000, Daniel P. Berrange wrote:
On Fri, Jan 07, 2011 at 02:17:37PM +0000, Neil Wilson wrote:
This documentation change fixes the description of vnc_password in qemu.conf to fit the behaviour introduced in commit ab952024f42726a291d2c0ceda10071b88da7533 which treats a non-existent VNC password and an empty string password in the same way.
No this is not correct. If the password is set to "", then QEMU should be denying access when the ',password' flag is set on the command line.
The behaviour you're seeing is a bug recently introduced in the QEMU monitor password command handling by QEMU GIT repo changeset 52c18be9e99dabe295321153fda7fce9f76647ac. Daniel
On Fri, 2011-01-07 at 14:51 +0000, Daniel P. Berrange wrote:
On Fri, Jan 07, 2011 at 02:38:05PM +0000, Daniel P. Berrange wrote:
On Fri, Jan 07, 2011 at 02:17:37PM +0000, Neil Wilson wrote:
This documentation change fixes the description of vnc_password in qemu.conf to fit the behaviour introduced in commit ab952024f42726a291d2c0ceda10071b88da7533 which treats a non-existent VNC password and an empty string password in the same way.
No this is not correct. If the password is set to "", then QEMU should be denying access when the ',password' flag is set on the command line.
The behaviour you're seeing is a bug recently introduced in the QEMU monitor password command handling by QEMU GIT repo changeset 52c18be9e99dabe295321153fda7fce9f76647ac.
Just checked back on RHEL5 and it works there. RHEL6 (at least my version) and Ubuntu Maverick are affected though. Apologies for the noise. Neil
participants (2)
-
Daniel P. Berrange -
Neil Wilson