[libvirt] [PATCH] virsh: fix a typos issue cause error not right

Signed-off-by: Luyao Huang <lhuang@redhat.com> --- tools/virsh-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-host.c b/tools/virsh-host.c index a72fd05..e939dac 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -500,7 +500,7 @@ cmdAllocpages(vshControl *ctl, const vshCmd *cmd) if (vshCommandOptScaledInt(cmd, "pagesize", &tmp, 1024, UINT_MAX) < 0) { vshError(ctl, _("Numeric value for <%s> option is malformed or out of range"), - "cellno"); + "pagesize"); return false; } pageSizes[0] = VIR_DIV_UP(tmp, 1024); -- 1.8.3.1

On 05/20/2015 09:32 PM, Luyao Huang wrote:
Signed-off-by: Luyao Huang <lhuang@redhat.com> --- tools/virsh-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
While correct, this would also be fixed by patches on list for "more common" virsh error message processing currently by Andrea Bolognani, see: http://www.redhat.com/archives/libvir-list/2015-May/msg00686.html Let's see where that series goes first... John
diff --git a/tools/virsh-host.c b/tools/virsh-host.c index a72fd05..e939dac 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -500,7 +500,7 @@ cmdAllocpages(vshControl *ctl, const vshCmd *cmd) if (vshCommandOptScaledInt(cmd, "pagesize", &tmp, 1024, UINT_MAX) < 0) { vshError(ctl, _("Numeric value for <%s> option is malformed or out of range"), - "cellno"); + "pagesize"); return false; } pageSizes[0] = VIR_DIV_UP(tmp, 1024);

On 05/21/2015 08:41 PM, John Ferlan wrote:
On 05/20/2015 09:32 PM, Luyao Huang wrote:
Signed-off-by: Luyao Huang <lhuang@redhat.com> --- tools/virsh-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
While correct, this would also be fixed by patches on list for "more common" virsh error message processing currently by Andrea Bolognani, see:
http://www.redhat.com/archives/libvir-list/2015-May/msg00686.html
Let's see where that series goes first...
Oh, you are right, this issue will be fixed after Andrea's patch is pushed. Thanks for your quick review.
John
Luyao
participants (3)
-
John Ferlan
-
lhuang
-
Luyao Huang