[PATCH 0/2] Improve the validation for queues and queue_size
Han Han (2): conf/domain_validate.c: Improve the err for queue validation conf/domain_validate: Validate the disk queue_size src/conf/domain_validate.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) -- 2.41.0
Queues is supported by virtio bus, including virtio-blk and vhost-user-blk. Signed-off-by: Han Han <hhan@redhat.com> --- src/conf/domain_validate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 16bf3b559f..e835ad33ad 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -784,7 +784,7 @@ virDomainDiskDefValidate(const virDomainDef *def, if (disk->queues) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("queues attribute in disk driver element is only supported by virtio-blk")); + _("queues attribute in disk driver element is only supported for virtio bus")); return -1; } -- 2.41.0
Signed-off-by: Han Han <hhan@redhat.com> --- src/conf/domain_validate.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index e835ad33ad..ad383b604e 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -788,6 +788,12 @@ virDomainDiskDefValidate(const virDomainDef *def, return -1; } + if (disk->queue_size) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("queue_size attribute in disk driver is only supported for virtio bus")); + return -1; + } + if (disk->event_idx != VIR_TRISTATE_SWITCH_ABSENT) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("disk event_idx mode supported only for virtio bus")); -- 2.41.0
On 7/21/23 04:36, Han Han wrote:
Han Han (2): conf/domain_validate.c: Improve the err for queue validation conf/domain_validate: Validate the disk queue_size
src/conf/domain_validate.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
Reviewed-by: Michal Privoznik <mprivozn@redhat.com> and pushed. Michal
participants (2)
-
Han Han -
Michal Prívozník