[libvirt] [PATCH] util : fix compile error on fedora14 Add src/util/virnetdevbandwidth.h, src/util/virnetdevveth.h, src/util/virnetdevvportprofile.h to private symbols.
From: Eli Qiao <taget@linux.vnet.ibm.com> Signed-off-by: Eli Qiao <taget@linux.vnet.ibm.com> --- src/libvirt_private.syms | 19 +++++++++++++++++++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 7b96a3c..f178662 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1201,9 +1201,19 @@ virNetDevSetIPv4Address; virNetDevSetMAC; virNetDevSetMTU; virNetDevSetMTUFromDevice; +virNetDevSetName; +virNetDevSetNamespace; virNetDevSetOnline; +# virnetdevbandwidth.h +virNetDevBandwidthClear; +virNetDevBandwidthCopy; +virNetDevBandwidthEqual; +virNetDevBandwidthFree; +virNetDevBandwidthSet; + + # virnetdevbridge.h virNetDevBridgeAddPort; virNetDevBridgeCreate; @@ -1221,6 +1231,15 @@ virNetDevTapCreateInBridgePort; virNetDevTapDelete; +# virnetdevveth.h +virNetDevVethCreate; +virNetDevVethDelete; + + +# virnetdevvportprofile.h +virNetDevVPortProfileEqual; + + # virnetmessage.h virNetMessageClear; virNetMessageDecodeNumFDs; -- 1.7.4.4
I got the compile error too on RHEL workstation 6.1 with latest git source, and this patch fixes it. On 11/16/2011 09:36 AM, taget@linux.vnet.ibm.com wrote:
From: Eli Qiao <taget@linux.vnet.ibm.com>
Signed-off-by: Eli Qiao <taget@linux.vnet.ibm.com> --- src/libvirt_private.syms | 19 +++++++++++++++++++ 1 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 7b96a3c..f178662 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1201,9 +1201,19 @@ virNetDevSetIPv4Address; virNetDevSetMAC; virNetDevSetMTU; virNetDevSetMTUFromDevice; +virNetDevSetName; +virNetDevSetNamespace; virNetDevSetOnline;
+# virnetdevbandwidth.h +virNetDevBandwidthClear; +virNetDevBandwidthCopy; +virNetDevBandwidthEqual; +virNetDevBandwidthFree; +virNetDevBandwidthSet; + + # virnetdevbridge.h virNetDevBridgeAddPort; virNetDevBridgeCreate; @@ -1221,6 +1231,15 @@ virNetDevTapCreateInBridgePort; virNetDevTapDelete;
+# virnetdevveth.h +virNetDevVethCreate; +virNetDevVethDelete; + + +# virnetdevvportprofile.h +virNetDevVPortProfileEqual; + + # virnetmessage.h virNetMessageClear; virNetMessageDecodeNumFDs;
-- Thanks. Hong Xiang
于 2011年11月16日 09:36, taget@linux.vnet.ibm.com 写道:
From: Eli Qiao<taget@linux.vnet.ibm.com>
Signed-off-by: Eli Qiao<taget@linux.vnet.ibm.com> --- src/libvirt_private.syms | 19 +++++++++++++++++++ 1 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 7b96a3c..f178662 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1201,9 +1201,19 @@ virNetDevSetIPv4Address; virNetDevSetMAC; virNetDevSetMTU; virNetDevSetMTUFromDevice; +virNetDevSetName; +virNetDevSetNamespace; virNetDevSetOnline;
+# virnetdevbandwidth.h +virNetDevBandwidthClear; +virNetDevBandwidthCopy; +virNetDevBandwidthEqual; +virNetDevBandwidthFree; +virNetDevBandwidthSet; + + # virnetdevbridge.h virNetDevBridgeAddPort; virNetDevBridgeCreate; @@ -1221,6 +1231,15 @@ virNetDevTapCreateInBridgePort; virNetDevTapDelete;
+# virnetdevveth.h +virNetDevVethCreate; +virNetDevVethDelete; + + +# virnetdevvportprofile.h +virNetDevVPortProfileEqual; + + # virnetmessage.h virNetMessageClear; virNetMessageDecodeNumFDs;
Straightforward, ACK, but there is a trailing whitespace and the patch subject is too long, pushed with the trainling whitespace removed and patch subject shortened as: util: Add netdev helper functions to private symbols Thanks Osier
于 2011年11月16日 11:02, Osier Yang 写道:
于 2011年11月16日 09:36, taget@linux.vnet.ibm.com 写道:
From: Eli Qiao<taget@linux.vnet.ibm.com>
Signed-off-by: Eli Qiao<taget@linux.vnet.ibm.com> --- src/libvirt_private.syms | 19 +++++++++++++++++++ 1 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 7b96a3c..f178662 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1201,9 +1201,19 @@ virNetDevSetIPv4Address; virNetDevSetMAC; virNetDevSetMTU; virNetDevSetMTUFromDevice; +virNetDevSetName; +virNetDevSetNamespace; virNetDevSetOnline;
+# virnetdevbandwidth.h +virNetDevBandwidthClear; +virNetDevBandwidthCopy; +virNetDevBandwidthEqual; +virNetDevBandwidthFree; +virNetDevBandwidthSet; + + # virnetdevbridge.h virNetDevBridgeAddPort; virNetDevBridgeCreate; @@ -1221,6 +1231,15 @@ virNetDevTapCreateInBridgePort; virNetDevTapDelete;
+# virnetdevveth.h +virNetDevVethCreate; +virNetDevVethDelete; + + +# virnetdevvportprofile.h +virNetDevVPortProfileEqual; + + # virnetmessage.h virNetMessageClear; virNetMessageDecodeNumFDs;
Straightforward, ACK, but there is a trailing whitespace and the patch subject is too long, pushed with the trainling whitespace removed and patch subject shortened as:
thanks Osier.
util: Add netdev helper functions to private symbols
Thanks Osier
-- best regards eli
On Wed, Nov 16, 2011 at 09:36:06AM +0800, taget@linux.vnet.ibm.com wrote:
From: Eli Qiao <taget@linux.vnet.ibm.com>
Signed-off-by: Eli Qiao <taget@linux.vnet.ibm.com> --- src/libvirt_private.syms | 19 +++++++++++++++++++ 1 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 7b96a3c..f178662 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1201,9 +1201,19 @@ virNetDevSetIPv4Address; virNetDevSetMAC; virNetDevSetMTU; virNetDevSetMTUFromDevice; +virNetDevSetName; +virNetDevSetNamespace; virNetDevSetOnline;
+# virnetdevbandwidth.h +virNetDevBandwidthClear; +virNetDevBandwidthCopy; +virNetDevBandwidthEqual; +virNetDevBandwidthFree; +virNetDevBandwidthSet; + + # virnetdevbridge.h virNetDevBridgeAddPort; virNetDevBridgeCreate; @@ -1221,6 +1231,15 @@ virNetDevTapCreateInBridgePort; virNetDevTapDelete;
+# virnetdevveth.h +virNetDevVethCreate; +virNetDevVethDelete; + + +# virnetdevvportprofile.h +virNetDevVPortProfileEqual; + + # virnetmessage.h virNetMessageClear; virNetMessageDecodeNumFDs;
ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
participants (5)
-
Daniel P. Berrange -
Eli Qiao -
Hong Xiang -
Osier Yang -
taget＠linux.vnet.ibm.com