[libvirt] [PATCH] qemu: Use correct variable in qemuDomainSetBlockIoTune
'param' contains the correct element from 'params'. If the group name would not be the first element libvirtd would crash. Introduced in c53bd25b13. --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index cd513ff9f..67f54282a 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -17443,7 +17443,7 @@ qemuDomainSetBlockIoTune(virDomainPtr dom, /* NB: Cannot use macro since this is a value.s not a value.ul */ if (STREQ(param->field, VIR_DOMAIN_BLOCK_IOTUNE_GROUP_NAME)) { - if (VIR_STRDUP(info.group_name, params->value.s) < 0) + if (VIR_STRDUP(info.group_name, param->value.s) < 0) goto endjob; set_fields |= QEMU_BLOCK_IOTUNE_SET_GROUP_NAME; if (virTypedParamsAddString(&eventParams, &eventNparams, -- 2.12.2
On Thu, May 25, 2017 at 01:17:08PM +0200, Peter Krempa wrote:
'param' contains the correct element from 'params'.
If the group name would not be the first element libvirtd would crash.
Introduced in c53bd25b13. --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
On Thu, May 25, 2017 at 01:17:08PM +0200, Peter Krempa wrote:
'param' contains the correct element from 'params'.
If the group name would not be the first element libvirtd would crash.
Is there a public bug you could link here?
Introduced in c53bd25b13. --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK Jan
On Thu, May 25, 2017 at 13:47:56 +0200, Ján Tomko wrote:
On Thu, May 25, 2017 at 01:17:08PM +0200, Peter Krempa wrote:
'param' contains the correct element from 'params'.
If the group name would not be the first element libvirtd would crash.
Is there a public bug you could link here?
There is now. I'll link it prior to pushing.
participants (3)
-
Ján Tomko -
Pavel Hrdina -
Peter Krempa