[libvirt] [PATCH] sanitytest.py: Do not rely on system libvirt
When running sanitytest.py we should not rely on libvirt library installed on the system. And since we generate a nice wrapper called "run" that sets both PYTHON_PATH and LD_LIBRARY_PATH, we should just use it rather than trying to duplicate it in the Makefile. --- python/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/Makefile.am b/python/Makefile.am index ef3c3eb..55c5e41 100644 --- a/python/Makefile.am +++ b/python/Makefile.am @@ -122,7 +122,7 @@ $(libvirtmod_lxc_la_OBJECTS): $(LXC_GENERATED) EXTRA_DIST += sanitytest.py check-local: - $(AM_V_GEN)PYTHONPATH=$(abs_topbuilddir):$(abs_topbuilddir)/.libs $(PYTHON) $(srcdir)/sanitytest.py + $(AM_V_GEN)../run $(PYTHON) $(srcdir)/sanitytest.py install-data-local: $(mkinstalldirs) $(DESTDIR)$(pyexecdir) -- 1.8.1.2
On 02/05/2013 12:33 PM, Jiri Denemark wrote:
When running sanitytest.py we should not rely on libvirt library installed on the system. And since we generate a nice wrapper called "run" that sets both PYTHON_PATH and LD_LIBRARY_PATH, we should just use it rather than trying to duplicate it in the Makefile. --- python/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/python/Makefile.am b/python/Makefile.am index ef3c3eb..55c5e41 100644 --- a/python/Makefile.am +++ b/python/Makefile.am @@ -122,7 +122,7 @@ $(libvirtmod_lxc_la_OBJECTS): $(LXC_GENERATED) EXTRA_DIST += sanitytest.py
check-local: - $(AM_V_GEN)PYTHONPATH=$(abs_topbuilddir):$(abs_topbuilddir)/.libs $(PYTHON) $(srcdir)/sanitytest.py + $(AM_V_GEN)../run $(PYTHON) $(srcdir)/sanitytest.py
ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On Tue, Feb 05, 2013 at 12:58:53 -0700, Eric Blake wrote:
On 02/05/2013 12:33 PM, Jiri Denemark wrote:
When running sanitytest.py we should not rely on libvirt library installed on the system. And since we generate a nice wrapper called "run" that sets both PYTHON_PATH and LD_LIBRARY_PATH, we should just use it rather than trying to duplicate it in the Makefile. --- python/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/python/Makefile.am b/python/Makefile.am index ef3c3eb..55c5e41 100644 --- a/python/Makefile.am +++ b/python/Makefile.am @@ -122,7 +122,7 @@ $(libvirtmod_lxc_la_OBJECTS): $(LXC_GENERATED) EXTRA_DIST += sanitytest.py
check-local: - $(AM_V_GEN)PYTHONPATH=$(abs_topbuilddir):$(abs_topbuilddir)/.libs $(PYTHON) $(srcdir)/sanitytest.py + $(AM_V_GEN)../run $(PYTHON) $(srcdir)/sanitytest.py
ACK.
Pushed, thanks. Jirka
participants (2)
-
Eric Blake -
Jiri Denemark