On 06/27/2011 04:12 AM, Daniel P. Berrange wrote:
On Mon, Jun 27, 2011 at 04:40:56PM +0900, Minoru Usui wrote:
> Fix lack of error check in virSysinfoFormat().
>
> Signed-off-by: Minoru Usui <usui(a)mxm.nes.nec.co.jp>
> ---
> src/util/sysinfo.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/src/util/sysinfo.c b/src/util/sysinfo.c
> index 31ebdc2..bff1cb8 100644
> --- a/src/util/sysinfo.c
> +++ b/src/util/sysinfo.c
> @@ -796,6 +796,11 @@ virSysinfoFormat(virSysinfoDefPtr def, const char *prefix)
>
> virBufferAsprintf(&buf, "%s</sysinfo>\n", prefix);
>
> + if (virBufferError(&buf)) {
> + virReportOOMError();
> + return NULL;
> + }
> +
> return virBufferContentAndReset(&buf);
> }
ACK
Pushed.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org