[libvirt] [PATCH] admin: Fix passing an incorrect readonly attribute to virNetServerServiceNew

When registering admin UNIX socket, a new service is created for it. This service is incorrectly initialized to be readonly, which is later inherited by all clients connected to the socket. In libvirt-admin's case there currently isn't any use for the attribute anyway, but since the socket has root-only access permissions, but the least we can do is to make every admin client connected to it report readonly as false. Signed-off-by: Erik Skultety <eskultet@redhat.com> --- daemon/libvirtd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index cc5190f..f24fb22 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -543,7 +543,7 @@ daemonSetupNetworking(virNetServerPtr srv, #if WITH_GNUTLS NULL, #endif - true, + false, config->admin_max_queued_clients, config->admin_max_client_requests))) goto cleanup; -- 2.5.5

On Sat, May 14, 2016 at 07:30:52PM +0200, Erik Skultety wrote:
When registering admin UNIX socket, a new service is created for it. This service is incorrectly initialized to be readonly, which is later inherited by all clients connected to the socket. In libvirt-admin's case there currently isn't any use for the attribute anyway, but since the socket has root-only access permissions, but the least we can do is to make every admin client connected to it report readonly as false.
Signed-off-by: Erik Skultety <eskultet@redhat.com> --- daemon/libvirtd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK Jan

On 16/05/16 16:19, Ján Tomko wrote:
On Sat, May 14, 2016 at 07:30:52PM +0200, Erik Skultety wrote:
When registering admin UNIX socket, a new service is created for it. This service is incorrectly initialized to be readonly, which is later inherited by all clients connected to the socket. In libvirt-admin's case there currently isn't any use for the attribute anyway, but since the socket has root-only access permissions, but the least we can do is to make every admin client connected to it report readonly as false.
Signed-off-by: Erik Skultety <eskultet@redhat.com> --- daemon/libvirtd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK
Jan
Thanks, pushed. Erik
participants (2)
-
Erik Skultety
-
Ján Tomko