[libvirt] [PATCH] virsh domjobinfo: Do not return 1 if job is NONE
Commit 38ab1225 changed the default value of ret from true to false but forgot to set ret = true when job is NONE. Thus, virsh domjobinfo returned 1 when there was no job running for a domain but it used to (and should) return 0 in this case. --- tools/virsh-domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 74feca1..3479a1c 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -5018,6 +5018,7 @@ cmdDomjobinfo(vshControl *ctl, const vshCmd *cmd) case VIR_DOMAIN_JOB_NONE: default: vshPrint(ctl, "%-12s\n", _("None")); + ret = true; goto cleanup; } -- 1.8.3.2
On 09/11/2013 04:16 PM, Jiri Denemark wrote:
Commit 38ab1225 changed the default value of ret from true to false but forgot to set ret = true when job is NONE. Thus, virsh domjobinfo returned 1 when there was no job running for a domain but it used to (and should) return 0 in this case. --- tools/virsh-domain.c | 1 + 1 file changed, 1 insertion(+)
ACK It would be nice to include the bug link in the commit message: https://bugzilla.redhat.com/show_bug.cgi?id=1006864 Jan
On Wed, Sep 11, 2013 at 16:54:21 +0200, Jano Tomko wrote:
On 09/11/2013 04:16 PM, Jiri Denemark wrote:
Commit 38ab1225 changed the default value of ret from true to false but forgot to set ret = true when job is NONE. Thus, virsh domjobinfo returned 1 when there was no job running for a domain but it used to (and should) return 0 in this case. --- tools/virsh-domain.c | 1 + 1 file changed, 1 insertion(+)
ACK
It would be nice to include the bug link in the commit message: https://bugzilla.redhat.com/show_bug.cgi?id=1006864
Yeah, I realized it too late. Added and pushed. Jirka
participants (2)
-
Jiri Denemark -
Ján Tomko