[libvirt] RFC Parallels driver renaming
Hi all, You probably already know that our Parallels business devision responsible for Parallels Cloud Server, which is supported currently in libvirt as a "parallels" driver, was recently renamed to Odin [1]. As a part of this change our Parallels Cloud Server product name was also changed to Virtuozzo [2]. That said, we need to address this change in all publicly available products and projects and libvirt is not an exception. Thus, I intend to do the following renaming: 1. connection uri from "parallels" to "vz", 2. driver directory and source files from "parallels" to "vz", 3. internal names (function prefixes, variable and other names) from "parallels", "prl" to "vz". I would like to request for comments about proposed renamings, if they are affordable? If so, I will send the patch series shortly. Maxim Nestratov --- [1] http://www.odin.com/odin/ [2] http://www.odin.com/products/virtuozzo/#tab4
On Thu, May 07, 2015 at 06:13:27PM +0300, Maxim Nestratov wrote:
Hi all,
You probably already know that our Parallels business devision responsible for Parallels Cloud Server, which is supported currently in libvirt as a "parallels" driver, was recently renamed to Odin [1]. As a part of this change our Parallels Cloud Server product name was also changed to Virtuozzo [2]. That said, we need to address this change in all publicly available products and projects and libvirt is not an exception. Thus, I intend to do the following renaming: 1. connection uri from "parallels" to "vz", 2. driver directory and source files from "parallels" to "vz", 3. internal names (function prefixes, variable and other names) from "parallels", "prl" to "vz".
I would like to request for comments about proposed renamings, if they are affordable? If so, I will send the patch series shortly.
The function names and file names are not a problem, since that does not affect external applications at all. Libvirt promises to maintain 100% application compatibility though across releases. So for the URI, we need to keep compatibility with existing syntax. That doesn't mean we can't rename the URI to have a vz:// prefix, but the code would have to still permit the old parallels:// prefix forever. Also, anywhere in the XML which refers to the parallels will have to continue to refer to that. For example <domain type="parallels"> cannot be changed, and virConnectGetType() will have to continue to return "Parallels". I can't remember if there are any other similar places. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
07.05.2015 18:53, Daniel P. Berrange пишет:
So for the URI, we need to keep compatibility with existing syntax. That doesn't mean we can't rename the URI to have a vz:// prefix, but the code would have to still permit the old parallels:// prefix forever.
Also, anywhere in the XML which refers to the parallels will have to continue to refer to that. For example <domain type="parallels"> cannot be changed, and virConnectGetType() will have to continue to return "Parallels". I can't remember if there are any other similar places. Ok. I'll keep backward compatibility in my changes. Thank you.
On Thu, May 07, 2015 at 07:34:09PM +0300, Maxim Nestratov wrote:
07.05.2015 18:53, Daniel P. Berrange пишет:
So for the URI, we need to keep compatibility with existing syntax. That doesn't mean we can't rename the URI to have a vz:// prefix, but the code would have to still permit the old parallels:// prefix forever.
Also, anywhere in the XML which refers to the parallels will have to continue to refer to that. For example <domain type="parallels"> cannot be changed, and virConnectGetType() will have to continue to return "Parallels". I can't remember if there are any other similar places. Ok. I'll keep backward compatibility in my changes.
BTW, rather than doing all the changes in one single patch, it'd be preferrable to split it up into several stages - large renaming patches tend to get quite hard to follow if too much is changed in one go Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
07.05.2015 19:45, Daniel P. Berrange пишет:
07.05.2015 18:53, Daniel P. Berrange пишет:
So for the URI, we need to keep compatibility with existing syntax. That doesn't mean we can't rename the URI to have a vz:// prefix, but the code would have to still permit the old parallels:// prefix forever.
Also, anywhere in the XML which refers to the parallels will have to continue to refer to that. For example <domain type="parallels"> cannot be changed, and virConnectGetType() will have to continue to return "Parallels". I can't remember if there are any other similar places. Ok. I'll keep backward compatibility in my changes. BTW, rather than doing all the changes in one single patch, it'd be
On Thu, May 07, 2015 at 07:34:09PM +0300, Maxim Nestratov wrote: preferrable to split it up into several stages - large renaming patches tend to get quite hard to follow if too much is changed in one go
Regards, Daniel Sure. This is the way I wanted to go.
participants (2)
-
Daniel P. Berrange -
Maxim Nestratov