[libvirt] question: about iothreads count restrict in virDomainDefCheckABIStabilityFlags

Hi, Migrate feature have a restrict: target domain iothreads count must match source The relevant code as follows: ------------------------------------ if (src->niothreadids != dst->niothreadids) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Target domain iothreads count %zu does not " "match source %zu"), dst->niothreadids, src->niothreadids); goto error; } ------------------------------------ I tried to remove the restrict, and perform migrate in that case: "target domain iothreads count does not match source" , Anything is normal! So, can we remove the restrict to support this case?

On Tue, Jan 29, 2019 at 05:33:30PM +0800, WangJie (Pluto) wrote:
Hi,
Migrate feature have a restrict: target domain iothreads count must match source
The relevant code as follows:
------------------------------------
if (src->niothreadids != dst->niothreadids) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Target domain iothreads count %zu does not " "match source %zu"), dst->niothreadids, src->niothreadids); goto error; }
------------------------------------
I tried to remove the restrict, and perform migrate in that case: "target domain iothreads count does not match source" , Anything is normal!
So, can we remove the restrict to support this case?
The number of i/o threads is not part of the vm state sent during migration, nor exposed to the guest ABI, so this restriction is a mistaken in libvirt. We should remove that bit of code. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
participants (2)
-
Daniel P. Berrangé
-
WangJie (Pluto)