[libvirt] [PATCH] Set correct device type when parsing input devices
In virDomainDeviceDefParse, parsing an input device was actually setting it's type as DEVICE_DISK. The attached patch fixes this. Thanks, Cole commit 75150ac2536c427f74875fc563abf2fc06595dda Author: Cole Robinson <crobinso@dhcp-100-19-219.bos.redhat.com> Date: Thu Aug 21 13:27:38 2008 -0400 Fix setting input device type in virDomainDeviceDefParse. diff --git a/src/domain_conf.c b/src/domain_conf.c index d482e68..6b23474 100644 --- a/src/domain_conf.c +++ b/src/domain_conf.c @@ -1656,7 +1656,7 @@ virDomainDeviceDefPtr virDomainDeviceDefParse(virConnectPtr conn, if (!(dev->data.net = virDomainNetDefParseXML(conn, node))) goto error; } else if (xmlStrEqual(node->name, BAD_CAST "input")) { - dev->type = VIR_DOMAIN_DEVICE_DISK; + dev->type = VIR_DOMAIN_DEVICE_INPUT; if (!(dev->data.input = virDomainInputDefParseXML(conn, def->os.type, node))) goto error; } else if (xmlStrEqual(node->name, BAD_CAST "sound")) {
On Thu, Aug 21, 2008 at 11:19:47PM -0400, Cole Robinson wrote:
In virDomainDeviceDefParse, parsing an input device was actually setting it's type as DEVICE_DISK. The attached patch fixes this.
+1 :-) Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones Read my OCaml programming blog: http://camltastic.blogspot.com/ Fedora now supports 60 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
On Thu, Aug 21, 2008 at 11:19:47PM -0400, Cole Robinson wrote:
In virDomainDeviceDefParse, parsing an input device was actually setting it's type as DEVICE_DISK. The attached patch fixes this.
ACK Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
On Thu, Aug 21, 2008 at 11:19:47PM -0400, Cole Robinson wrote:
In virDomainDeviceDefParse, parsing an input device was actually setting it's type as DEVICE_DISK. The attached patch fixes this.
Sure make sense ! Patch finally applied and commited to CVS, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
participants (4)
-
Cole Robinson -
Daniel P. Berrange -
Daniel Veillard -
Richard W.M. Jones