[libvirt] [PATCH 0/2] docs: Couple of improvements
CMSIA (Commit Messages Say It All) Michal Privoznik (2): docs: Add apps.html link to index.html docs: List go-libvirt in bindings docs/bindings.html.in | 14 ++++++++++++-- docs/index.html.in | 1 + 2 files changed, 13 insertions(+), 2 deletions(-) -- 2.8.4
I think when trying to introduce libvirt (we have a section for that in our index page) it might be useful to promote success stories - other applications that are based on libvirt. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- docs/index.html.in | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/index.html.in b/docs/index.html.in index b9a8461..7665f8c 100644 --- a/docs/index.html.in +++ b/docs/index.html.in @@ -39,6 +39,7 @@ <a href="drvbhyve.html">BHyve</a> and <a href="drivers.html">more</a></li> <li>targets Linux, FreeBSD, <a href="windows.html">Windows</a> and OS-X</li> + <li><a href="apps.html">applications</a> known to use libvirt</li> </ul> </div> -- 2.8.4
On Wed, Nov 23, 2016 at 08:48:42AM +0100, Michal Privoznik wrote:
I think when trying to introduce libvirt (we have a section for that in our index page) it might be useful to promote success stories - other applications that are based on libvirt.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- docs/index.html.in | 1 + 1 file changed, 1 insertion(+)
diff --git a/docs/index.html.in b/docs/index.html.in index b9a8461..7665f8c 100644 --- a/docs/index.html.in +++ b/docs/index.html.in @@ -39,6 +39,7 @@ <a href="drvbhyve.html">BHyve</a> and <a href="drivers.html">more</a></li> <li>targets Linux, FreeBSD, <a href="windows.html">Windows</a> and OS-X</li> + <li><a href="apps.html">applications</a> known to use libvirt</li> </ul> </div>
ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
On Wed, Nov 23, 2016 at 08:48:42AM +0100, Michal Privoznik wrote:
I think when trying to introduce libvirt (we have a section for that in our index page) it might be useful to promote success stories - other applications that are based on libvirt.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- docs/index.html.in | 1 + 1 file changed, 1 insertion(+)
diff --git a/docs/index.html.in b/docs/index.html.in index b9a8461..7665f8c 100644 --- a/docs/index.html.in +++ b/docs/index.html.in @@ -39,6 +39,7 @@ <a href="drvbhyve.html">BHyve</a> and <a href="drivers.html">more</a></li> <li>targets Linux, FreeBSD, <a href="windows.html">Windows</a> and OS-X</li> + <li><a href="apps.html">applications</a> known to use libvirt</li> </ul> </div>
I like this as a part of the intriduction block, but it should not be part of the list, but rather another paragraph in it. This way it completes the sentence in the beginning making it sound like this: "The libvirt project applications known to use libvirt". You can also leave it were it is and change it to: <li>is used by many <a href="apps.html">applications</a></li> or something similar.
-- 2.8.4
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
I've came across this site [1] which refers to yet another Go libvirt bindings. Add them to the list. 1: https://www.digitalocean.com/company/blog/introducing-go-qemu-and-go-libvirt... Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- docs/bindings.html.in | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/docs/bindings.html.in b/docs/bindings.html.in index 7fe26df..6f18c07 100644 --- a/docs/bindings.html.in +++ b/docs/bindings.html.in @@ -15,8 +15,18 @@ <a href="csharp.html">C# bindings</a>. </li> <li> - <strong>Go</strong>: Kyle Kelley et al. are developing - <a href="https://github.com/rgbkrk/libvirt-go">Go bindings</a>. + <strong>Go</strong>: There are two bindings available: + <a href="https://github.com/rgbkrk/libvirt-go">libvirt-go</a> and + <a href="https://github.com/digitalocean/go-libvirt">go-libvirt</a>. + <p> + The <tt>libvirt-go</tt> bindings are developed by Kyle Kelley et + al. and are built on the top of libvirt's client library. + </p> + <p> + The <tt>go-libvirt</tt> bindings are then developed by Ben + LeMasurier et al. and they hook straight into libvirt's RPC and thus do + not rely on <tt>cgo</tt>. + </p> </li> <li> <strong>Java</strong>: Daniel Veillard develops -- 2.8.4
On Wed, Nov 23, 2016 at 08:48:43AM +0100, Michal Privoznik wrote:
I've came across this site [1] which refers to yet another Go libvirt bindings. Add them to the list.
1: https://www.digitalocean.com/company/blog/introducing-go-qemu-and-go-libvirt...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- docs/bindings.html.in | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/docs/bindings.html.in b/docs/bindings.html.in index 7fe26df..6f18c07 100644 --- a/docs/bindings.html.in +++ b/docs/bindings.html.in @@ -15,8 +15,18 @@ <a href="csharp.html">C# bindings</a>. </li> <li> - <strong>Go</strong>: Kyle Kelley et al. are developing - <a href="https://github.com/rgbkrk/libvirt-go">Go bindings</a>. + <strong>Go</strong>: There are two bindings available: + <a href="https://github.com/rgbkrk/libvirt-go">libvirt-go</a> and + <a href="https://github.com/digitalocean/go-libvirt">go-libvirt</a>. + <p> + The <tt>libvirt-go</tt> bindings are developed by Kyle Kelley et + al. and are built on the top of libvirt's client library. + </p> + <p> + The <tt>go-libvirt</tt> bindings are then developed by Ben + LeMasurier et al. and they hook straight into libvirt's RPC and thus do + not rely on <tt>cgo</tt>. + </p>
I really think we should *not* encourage use of this binding, on the basis that we really don't want people hooking into the RPC system like this. It makes them less future proof and locks them out of using any of the drivers that are outside libvirtd, unless they want to tunnel access to them via libvirtd which is just stupid. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
On 23.11.2016 10:24, Daniel P. Berrange wrote:
On Wed, Nov 23, 2016 at 08:48:43AM +0100, Michal Privoznik wrote:
I've came across this site [1] which refers to yet another Go libvirt bindings. Add them to the list.
1: https://www.digitalocean.com/company/blog/introducing-go-qemu-and-go-libvirt...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- docs/bindings.html.in | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/docs/bindings.html.in b/docs/bindings.html.in index 7fe26df..6f18c07 100644 --- a/docs/bindings.html.in +++ b/docs/bindings.html.in @@ -15,8 +15,18 @@ <a href="csharp.html">C# bindings</a>. </li> <li> - <strong>Go</strong>: Kyle Kelley et al. are developing - <a href="https://github.com/rgbkrk/libvirt-go">Go bindings</a>. + <strong>Go</strong>: There are two bindings available: + <a href="https://github.com/rgbkrk/libvirt-go">libvirt-go</a> and + <a href="https://github.com/digitalocean/go-libvirt">go-libvirt</a>. + <p> + The <tt>libvirt-go</tt> bindings are developed by Kyle Kelley et + al. and are built on the top of libvirt's client library. + </p> + <p> + The <tt>go-libvirt</tt> bindings are then developed by Ben + LeMasurier et al. and they hook straight into libvirt's RPC and thus do + not rely on <tt>cgo</tt>. + </p>
I really think we should *not* encourage use of this binding, on the basis that we really don't want people hooking into the RPC system like this. It makes them less future proof and locks them out of using any of the drivers that are outside libvirtd, unless they want to tunnel access to them via libvirtd which is just stupid.
Fair enough. Frankly, I was surprised they do this and I am not in favour of them doing so, but I thought that shouldn't stop me from proposing this patch. Another reason is that there's not strictly 1:1 relationship between a libvirt API and RPC call. So after all I'm okay with dropping this patch. Michal
On Wed, Nov 23, 2016 at 09:24:19AM +0000, Daniel P. Berrange wrote:
On Wed, Nov 23, 2016 at 08:48:43AM +0100, Michal Privoznik wrote:
I've came across this site [1] which refers to yet another Go libvirt bindings. Add them to the list.
1: https://www.digitalocean.com/company/blog/introducing-go-qemu-and-go-libvirt...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- docs/bindings.html.in | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/docs/bindings.html.in b/docs/bindings.html.in index 7fe26df..6f18c07 100644 --- a/docs/bindings.html.in +++ b/docs/bindings.html.in @@ -15,8 +15,18 @@ <a href="csharp.html">C# bindings</a>. </li> <li> - <strong>Go</strong>: Kyle Kelley et al. are developing - <a href="https://github.com/rgbkrk/libvirt-go">Go bindings</a>. + <strong>Go</strong>: There are two bindings available: + <a href="https://github.com/rgbkrk/libvirt-go">libvirt-go</a> and + <a href="https://github.com/digitalocean/go-libvirt">go-libvirt</a>. + <p> + The <tt>libvirt-go</tt> bindings are developed by Kyle Kelley et + al. and are built on the top of libvirt's client library. + </p> + <p> + The <tt>go-libvirt</tt> bindings are then developed by Ben + LeMasurier et al. and they hook straight into libvirt's RPC and thus do + not rely on <tt>cgo</tt>. + </p>
I really think we should *not* encourage use of this binding, on the basis that we really don't want people hooking into the RPC system like this. It makes them less future proof and locks them out of using any of the drivers that are outside libvirtd, unless they want to tunnel access to them via libvirtd which is just stupid.
Also, I've spent the last 45 minutes finding a way of contacting someone to fix this false statement - "libvirt developers are free to change the API or RPC protocol at any time, potentially breaking go-libvirt" - since I refuse to log in with facebook or whatever social rubbish just to be able to comment on the article. Provided I didn't miss anything, they don't have any mailing list, nor any direct email contact, so I joined the IRC channel and provided my feedback there but I somehow doubt anyone cares really. Erik
Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
participants (4)
-
Daniel P. Berrange -
Erik Skultety -
Martin Kletzander -
Michal Privoznik