[libvirt] [PATCH libvirt-tck] Cleanup secret in disk encryption test

100-disk-encryption.t does not undefine the secret it defines for the test disk, causing subsequent runs of the test to fail not ok 1 - secret created Failed test 'secret created' at /usr/share/libvirt-tck/tests/qemu/100-disk-encryption.t line 65. died: Sys::Virt::Error (libvirt error code: 1, message: internal error: a secret with UUID 212c459b-b02c-41fc-8ae2-714cc31612c5 is already defined for use with /var/cache/libvirt-tck/300-disk-encryption/demo.qcow2 Signed-off-by: Jim Fehlig <jfehlig@suse.com> --- scripts/qemu/100-disk-encryption.t | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/qemu/100-disk-encryption.t b/scripts/qemu/100-disk-encryption.t index 32e2adf..1a36650 100644 --- a/scripts/qemu/100-disk-encryption.t +++ b/scripts/qemu/100-disk-encryption.t @@ -118,3 +118,5 @@ $dom->undefine; ok_error(sub { $conn->get_domain_by_name("tck") }, "NO_DOMAIN error raised from missing domain", 42); } + +$secret->undefine; -- 2.18.0

On Wed, Aug 08, 2018 at 02:44:54PM -0600, Jim Fehlig wrote:
100-disk-encryption.t does not undefine the secret it defines for the test disk, causing subsequent runs of the test to fail
not ok 1 - secret created Failed test 'secret created' at /usr/share/libvirt-tck/tests/qemu/100-disk-encryption.t line 65. died: Sys::Virt::Error (libvirt error code: 1, message: internal error: a secret with UUID 212c459b-b02c-41fc-8ae2-714cc31612c5 is already defined for use with /var/cache/libvirt-tck/300-disk-encryption/demo.qcow2
Signed-off-by: Jim Fehlig <jfehlig@suse.com> --- scripts/qemu/100-disk-encryption.t | 2 ++ 1 file changed, 2 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
participants (2)
-
Daniel P. Berrangé
-
Jim Fehlig