[libvirt] [PATCH] qemu: fix typo in spice migration code
This typo caused XPath returning improper value and thus not working spice after migration. --- src/qemu/qemu_migration.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index cb408ac..fcf8f9c 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -355,7 +355,7 @@ qemuMigrationCookieGraphicsXMLParse(xmlXPathContextPtr ctxt) goto error; } /* Optional */ - grap->tlsSubject = virXPathString("string(./graphics/cert[ info='subject']/@value)", ctxt); + grap->tlsSubject = virXPathString("string(./graphics/cert[@info='subject']/@value)", ctxt); return grap; -- 1.7.5.rc3
On Wed, May 18, 2011 at 11:59:34AM +0200, Michal Privoznik wrote:
This typo caused XPath returning improper value and thus not working spice after migration. --- src/qemu/qemu_migration.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index cb408ac..fcf8f9c 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -355,7 +355,7 @@ qemuMigrationCookieGraphicsXMLParse(xmlXPathContextPtr ctxt) goto error; } /* Optional */ - grap->tlsSubject = virXPathString("string(./graphics/cert[ info='subject']/@value)", ctxt); + grap->tlsSubject = virXPathString("string(./graphics/cert[@info='subject']/@value)", ctxt);
return grap;
ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On Wed, May 18, 2011 at 11:59:34AM +0200, Michal Privoznik wrote:
This typo caused XPath returning improper value and thus not working spice after migration. --- src/qemu/qemu_migration.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index cb408ac..fcf8f9c 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -355,7 +355,7 @@ qemuMigrationCookieGraphicsXMLParse(xmlXPathContextPtr ctxt) goto error; } /* Optional */ - grap->tlsSubject = virXPathString("string(./graphics/cert[ info='subject']/@value)", ctxt); + grap->tlsSubject = virXPathString("string(./graphics/cert[@info='subject']/@value)", ctxt);
return grap;
ACK
Daniel
On 18.05.2011 15:02, Daniel P. Berrange wrote: thanks. pushed.
participants (3)
-
Daniel P. Berrange -
Michal Privoznik -
Michal Prívozník