[libvirt] [PATCH] Remove non-existent symbol from linker script
# HG changeset patch # User john.levon@sun.com # Date 1232574142 28800 # Node ID 0a35ce4ac7e0cf83df188dea0fc37818b4c39d48 # Parent fc06d88e4140cebc9d0b7795019c0c2741c3f8a9 Remove non-existent symbol from linker script Signed-off-by: John Levon <john.levon@sun.com> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -205,7 +205,6 @@ virNetworkObjListFree; virNetworkObjListFree; virNetworkDefParseNode; virNetworkRemoveInactive; -virNetworkSaveConfigXML; virNetworkSaveConfig; virNetworkObjLock; virNetworkObjUnlock;
On Wed, Jan 21, 2009 at 01:42:24PM -0800, john.levon@sun.com wrote:
# HG changeset patch # User john.levon@sun.com # Date 1232574142 28800 # Node ID 0a35ce4ac7e0cf83df188dea0fc37818b4c39d48 # Parent fc06d88e4140cebc9d0b7795019c0c2741c3f8a9 Remove non-existent symbol from linker script
Signed-off-by: John Levon <john.levon@sun.com>
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -205,7 +205,6 @@ virNetworkObjListFree; virNetworkObjListFree; virNetworkDefParseNode; virNetworkRemoveInactive; -virNetworkSaveConfigXML;
Actually this is a typo - it should be virNetworkSaveXML Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
On Thu, Jan 22, 2009 at 10:08:54AM +0000, Daniel P. Berrange wrote:
virNetworkRemoveInactive; -virNetworkSaveConfigXML;
Actually this is a typo - it should be virNetworkSaveXML
I thought that when I read your patch, but virNetworkSaveXML isn't used outside of network_conf.c, so I think my patch is still right. regards john
On Thu, Jan 22, 2009 at 05:22:03PM +0000, John Levon wrote:
On Thu, Jan 22, 2009 at 10:08:54AM +0000, Daniel P. Berrange wrote:
virNetworkRemoveInactive; -virNetworkSaveConfigXML;
Actually this is a typo - it should be virNetworkSaveXML
I thought that when I read your patch, but virNetworkSaveXML isn't used outside of network_conf.c, so I think my patch is still right.
Hmm, odd. I could have sworn I had a good reason for adding this extra method. Removing the sym is fine in this case Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
participants (4)
-
Daniel P. Berrange -
Jim Meyering -
John Levon -
john.levon＠sun.com