[libvirt] [jenkins-ci PATCH 0/2] Stop building Go projects on CentOS 7
Found while creating a new CentOS 7 guest from scratch using lcitool. See the commit messages for more details. Andrea Bolognani (2): Stop building Go projects on CentOS 7 guests: Don't prepare CentOS 7 for Go projects guests/host_vars/libvirt-centos-7/main.yml | 2 -- guests/playbooks/build/projects/libvirt-go-xml.yml | 13 ++++++++++++- guests/playbooks/build/projects/libvirt-go.yml | 13 ++++++++++++- projects/libvirt-go-xml.yaml | 9 ++++++++- projects/libvirt-go.yaml | 9 ++++++++- 5 files changed, 40 insertions(+), 6 deletions(-) -- 2.19.2
At some point during the life of CentOS 7, the Go compiler and related packages appear to has been moved from out of the base repositories and into EPEL. Since as a rule we only rely on first-party repositories to fulfill build requirements, this means we can no longer build Go projects on CentOS 7. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/playbooks/build/projects/libvirt-go-xml.yml | 13 ++++++++++++- guests/playbooks/build/projects/libvirt-go.yml | 13 ++++++++++++- projects/libvirt-go-xml.yaml | 9 ++++++++- projects/libvirt-go.yaml | 9 ++++++++- 4 files changed, 40 insertions(+), 4 deletions(-) diff --git a/guests/playbooks/build/projects/libvirt-go-xml.yml b/guests/playbooks/build/projects/libvirt-go-xml.yml index ef932b4..e132d47 100644 --- a/guests/playbooks/build/projects/libvirt-go-xml.yml +++ b/guests/playbooks/build/projects/libvirt-go-xml.yml @@ -1,7 +1,18 @@ --- - set_fact: name: libvirt-go-xml - machines: '{{ all_machines }}' + machines: + - libvirt-debian-8 + - libvirt-debian-9 + - libvirt-debian-sid + - libvirt-fedora-28 + - libvirt-fedora-29 + - libvirt-fedora-rawhide + - libvirt-freebsd-11 + - libvirt-freebsd-12 + - libvirt-freebsd-current + - libvirt-ubuntu-16 + - libvirt-ubuntu-18 archive_format: gz git_url: '{{ git_urls["libvirt-go-xml"][git_remote] }}' diff --git a/guests/playbooks/build/projects/libvirt-go.yml b/guests/playbooks/build/projects/libvirt-go.yml index 6c59900..e008e24 100644 --- a/guests/playbooks/build/projects/libvirt-go.yml +++ b/guests/playbooks/build/projects/libvirt-go.yml @@ -1,7 +1,18 @@ --- - set_fact: name: libvirt-go - machines: '{{ all_machines }}' + machines: + - libvirt-debian-8 + - libvirt-debian-9 + - libvirt-debian-sid + - libvirt-fedora-28 + - libvirt-fedora-29 + - libvirt-fedora-rawhide + - libvirt-freebsd-11 + - libvirt-freebsd-12 + - libvirt-freebsd-current + - libvirt-ubuntu-16 + - libvirt-ubuntu-18 archive_format: gz git_url: '{{ git_urls["libvirt-go"][git_remote] }}' diff --git a/projects/libvirt-go-xml.yaml b/projects/libvirt-go-xml.yaml index 40a5d79..6f076de 100644 --- a/projects/libvirt-go-xml.yaml +++ b/projects/libvirt-go-xml.yaml @@ -1,7 +1,14 @@ - project: name: libvirt-go-xml - machines: '{all_machines}' + machines: + - libvirt-debian-8 + - libvirt-debian-9 + - libvirt-fedora-28 + - libvirt-fedora-29 + - libvirt-fedora-rawhide + - libvirt-freebsd-11 + - libvirt-freebsd-12 title: Libvirt Go XML archive_format: gz git_url: '{git_urls[libvirt-go-xml][default]}' diff --git a/projects/libvirt-go.yaml b/projects/libvirt-go.yaml index ed8e575..70586cb 100644 --- a/projects/libvirt-go.yaml +++ b/projects/libvirt-go.yaml @@ -1,7 +1,14 @@ - project: name: libvirt-go - machines: '{all_machines}' + machines: + - libvirt-debian-8 + - libvirt-debian-9 + - libvirt-fedora-28 + - libvirt-fedora-29 + - libvirt-fedora-rawhide + - libvirt-freebsd-11 + - libvirt-freebsd-12 title: Libvirt Go archive_format: gz git_url: '{git_urls[libvirt-go][default]}' -- 2.19.2
On Fri, Dec 21, 2018 at 4:15 AM Andrea Bolognani <abologna@redhat.com> wrote:
At some point during the life of CentOS 7, the Go compiler and related packages appear to has been moved from out of the base repositories and into EPEL.
Since as a rule we only rely on first-party repositories to fulfill build requirements, this means we can no longer build Go projects on CentOS 7.
Software Collections don't count as first-party repositories? The RHEL documentation recommends the Go Toolset in place of the deprecated golang package. That said, the golang package isn't gone, it's just a zombie now... -- 真実はいつも一つ！/ Always, there's only one truth!
On Sat, 2018-12-22 at 01:36 -0500, Neal Gompa wrote:
On Fri, Dec 21, 2018 at 4:15 AM Andrea Bolognani <abologna@redhat.com> wrote:
At some point during the life of CentOS 7, the Go compiler and related packages appear to has been moved from out of the base repositories and into EPEL.
Since as a rule we only rely on first-party repositories to fulfill build requirements, this means we can no longer build Go projects on CentOS 7.
Software Collections don't count as first-party repositories? The RHEL documentation recommends the Go Toolset in place of the deprecated golang package. That said, the golang package isn't gone, it's just a zombie now...
"First-party" might not the best word to describe it, but the general idea is that we want to limit ourselves to packages that are part of the operating system itself: this is mostly to maintain sanity, because otherwise answering questions such as "what is the newest version of Python available on $OS?" becomes quite tricky due to the existence of EPEL, Software Collections, backports and the like. We currently have two exceptions to the above: we install Java from backports on Debian 8, because otherwise we wouldn't be able to run the Jenkins agent, and we install the nodebug kernel on Rawhide because performance is quite awful with the regular one. Neither of those exceptions affect whether we support a certain platforms, so they're safe as far as I'm concerned. -- Andrea Bolognani / Red Hat / Virtualization
The corresponding packages are no longer available without enabling EPEL, which resulted in the update procedure failing. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/host_vars/libvirt-centos-7/main.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/guests/host_vars/libvirt-centos-7/main.yml b/guests/host_vars/libvirt-centos-7/main.yml index 8be54b6..741de62 100644 --- a/guests/host_vars/libvirt-centos-7/main.yml +++ b/guests/host_vars/libvirt-centos-7/main.yml @@ -5,8 +5,6 @@ projects: - libvirt-cim - libvirt-dbus - libvirt-glib - - libvirt-go - - libvirt-go-xml - libvirt-ocaml - libvirt-perl - libvirt-python -- 2.19.2
On Fri, Dec 21, 2018 at 10:15:31AM +0100, Andrea Bolognani wrote:
Found while creating a new CentOS 7 guest from scratch using lcitool. See the commit messages for more details.
Andrea Bolognani (2): Stop building Go projects on CentOS 7 guests: Don't prepare CentOS 7 for Go projects
guests/host_vars/libvirt-centos-7/main.yml | 2 -- guests/playbooks/build/projects/libvirt-go-xml.yml | 13 ++++++++++++- guests/playbooks/build/projects/libvirt-go.yml | 13 ++++++++++++- projects/libvirt-go-xml.yaml | 9 ++++++++- projects/libvirt-go.yaml | 9 ++++++++- 5 files changed, 40 insertions(+), 6 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
participants (3)
-
Andrea Bolognani -
Daniel P. Berrangé -
Neal Gompa