On 02/20/2013 01:11 PM, Eric Blake wrote:
On 02/20/2013 11:01 AM, John Ferlan wrote:
> While working on the hellolibvirt example code, I stumbled across a
> couple extraneous VIR_FREE()'s in qemuStop(). I was looking at all
> callers of virConnectListAllDomains()...
>
> ---
> src/qemu/qemu_driver.c | 3 ---
> 1 file changed, 3 deletions(-)
ACK. Generating this patch email with 'git send-email -U6' to expose
additional context (namely, that the very next two lines in cleanup: do
the same VIR_FREE) would have made review slightly easier; but that's a
trick which took me a while to learn.
Thanks for the review and tip (it's in my list of tips now).
Pushed.
John