[libvirt] [PATCH] Remove a couple of misplaced VIR_FREE
While working on the hellolibvirt example code, I stumbled across a couple extraneous VIR_FREE()'s in qemuStop(). I was looking at all callers of virConnectListAllDomains()... --- src/qemu/qemu_driver.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index be01ec6..45bd341 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -920,9 +920,6 @@ qemuStop(void) { if (virDomainManagedSave(domains[i], flags[i]) < 0) ret = -1; - VIR_FREE(domains); - VIR_FREE(flags); - cleanup: for (i = 0 ; i < numDomains ; i++) virDomainFree(domains[i]); -- 1.7.11.7
On 02/20/2013 11:01 AM, John Ferlan wrote:
While working on the hellolibvirt example code, I stumbled across a couple extraneous VIR_FREE()'s in qemuStop(). I was looking at all callers of virConnectListAllDomains()...
--- src/qemu/qemu_driver.c | 3 --- 1 file changed, 3 deletions(-)
ACK. Generating this patch email with 'git send-email -U6' to expose additional context (namely, that the very next two lines in cleanup: do the same VIR_FREE) would have made review slightly easier; but that's a trick which took me a while to learn. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On 02/20/2013 01:11 PM, Eric Blake wrote:
On 02/20/2013 11:01 AM, John Ferlan wrote:
While working on the hellolibvirt example code, I stumbled across a couple extraneous VIR_FREE()'s in qemuStop(). I was looking at all callers of virConnectListAllDomains()...
--- src/qemu/qemu_driver.c | 3 --- 1 file changed, 3 deletions(-)
ACK. Generating this patch email with 'git send-email -U6' to expose additional context (namely, that the very next two lines in cleanup: do the same VIR_FREE) would have made review slightly easier; but that's a trick which took me a while to learn.
Thanks for the review and tip (it's in my list of tips now). Pushed. John
participants (2)
-
Eric Blake -
John Ferlan