[libvirt] [PATCH 0/5] Fill qemucapabilitiesdata with some data
The actual patches are accessible at: git://gitorious.org/libvirt/michal-staging.git branch test_qemu_capabilities_data I'm not sending the actual patches as it's big junk of JSON qemu replies. The patches has from 35KiB to 59KiB. I don't want to overload the list. Michal Privoznik (5): qemucapabilitiesdata: Add qemu-1.2.2 data qemucapabilitiesdata: Add qemu-1.3.1 data qemucapabilitiesdata: Add qemu-1.4.2 data qemucapabilitiesdata: Add qemu-1.6.0 data qemucapabilitiesdata: Add qemu-1.6.50 data tests/qemucapabilitiesdata/caps_1.2.2-1.caps | 114 + tests/qemucapabilitiesdata/caps_1.2.2-1.replies | 1543 +++++++++++++ tests/qemucapabilitiesdata/caps_1.3.1-1.caps | 128 ++ tests/qemucapabilitiesdata/caps_1.3.1-1.replies | 1715 +++++++++++++++ tests/qemucapabilitiesdata/caps_1.4.2-1.caps | 129 ++ tests/qemucapabilitiesdata/caps_1.4.2-1.replies | 1765 +++++++++++++++ tests/qemucapabilitiesdata/caps_1.6.0-1.caps | 137 ++ tests/qemucapabilitiesdata/caps_1.6.0-1.replies | 2499 ++++++++++++++++++++++ tests/qemucapabilitiesdata/caps_1.6.50-1.caps | 136 ++ tests/qemucapabilitiesdata/caps_1.6.50-1.replies | 2476 +++++++++++++++++++++ tests/qemucapabilitiestest.c | 5 + 11 files changed, 10647 insertions(+) create mode 100644 tests/qemucapabilitiesdata/caps_1.2.2-1.caps create mode 100644 tests/qemucapabilitiesdata/caps_1.2.2-1.replies create mode 100644 tests/qemucapabilitiesdata/caps_1.3.1-1.caps create mode 100644 tests/qemucapabilitiesdata/caps_1.3.1-1.replies create mode 100644 tests/qemucapabilitiesdata/caps_1.4.2-1.caps create mode 100644 tests/qemucapabilitiesdata/caps_1.4.2-1.replies create mode 100644 tests/qemucapabilitiesdata/caps_1.6.0-1.caps create mode 100644 tests/qemucapabilitiesdata/caps_1.6.0-1.replies create mode 100644 tests/qemucapabilitiesdata/caps_1.6.50-1.caps create mode 100644 tests/qemucapabilitiesdata/caps_1.6.50-1.replies -- 1.8.1.5
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- tests/qemucapabilitiesdata/caps_1.2.2-1.caps | 114 ++ tests/qemucapabilitiesdata/caps_1.2.2-1.replies | 1543 +++++++++++++++++++++++ tests/qemucapabilitiestest.c | 1 + 3 files changed, 1658 insertions(+) create mode 100644 tests/qemucapabilitiesdata/caps_1.2.2-1.caps create mode 100644 tests/qemucapabilitiesdata/caps_1.2.2-1.replies
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- tests/qemucapabilitiesdata/caps_1.3.1-1.caps | 128 ++ tests/qemucapabilitiesdata/caps_1.3.1-1.replies | 1715 +++++++++++++++++++++++ tests/qemucapabilitiestest.c | 1 + 3 files changed, 1844 insertions(+) create mode 100644 tests/qemucapabilitiesdata/caps_1.3.1-1.caps create mode 100644 tests/qemucapabilitiesdata/caps_1.3.1-1.replies
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- tests/qemucapabilitiesdata/caps_1.4.2-1.caps | 129 ++ tests/qemucapabilitiesdata/caps_1.4.2-1.replies | 1765 +++++++++++++++++++++++ tests/qemucapabilitiestest.c | 1 + 3 files changed, 1895 insertions(+) create mode 100644 tests/qemucapabilitiesdata/caps_1.4.2-1.caps create mode 100644 tests/qemucapabilitiesdata/caps_1.4.2-1.replies
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- tests/qemucapabilitiesdata/caps_1.6.0-1.caps | 137 ++ tests/qemucapabilitiesdata/caps_1.6.0-1.replies | 2499 +++++++++++++++++++++++ tests/qemucapabilitiestest.c | 1 + 3 files changed, 2637 insertions(+) create mode 100644 tests/qemucapabilitiesdata/caps_1.6.0-1.caps create mode 100644 tests/qemucapabilitiesdata/caps_1.6.0-1.replies
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- tests/qemucapabilitiesdata/caps_1.6.50-1.caps | 136 ++ tests/qemucapabilitiesdata/caps_1.6.50-1.replies | 2476 ++++++++++++++++++++++ tests/qemucapabilitiestest.c | 1 + 3 files changed, 2613 insertions(+) create mode 100644 tests/qemucapabilitiesdata/caps_1.6.50-1.caps create mode 100644 tests/qemucapabilitiesdata/caps_1.6.50-1.replies
On 10/03/2013 07:25 AM, Michal Privoznik wrote:
The actual patches are accessible at:
git://gitorious.org/libvirt/michal-staging.git
branch test_qemu_capabilities_data
I'm not sending the actual patches as it's big junk of JSON qemu replies. The patches has from 35KiB to 59KiB. I don't want to overload the list.
Michal Privoznik (5): qemucapabilitiesdata: Add qemu-1.2.2 data qemucapabilitiesdata: Add qemu-1.3.1 data qemucapabilitiesdata: Add qemu-1.4.2 data qemucapabilitiesdata: Add qemu-1.6.0 data qemucapabilitiesdata: Add qemu-1.6.50 data
ACK series. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On Thu, Oct 3, 2013 at 9:12 AM, Eric Blake <eblake@redhat.com> wrote:
On 10/03/2013 07:25 AM, Michal Privoznik wrote:
The actual patches are accessible at:
git://gitorious.org/libvirt/michal-staging.git
branch test_qemu_capabilities_data
I'm not sending the actual patches as it's big junk of JSON qemu replies. The patches has from 35KiB to 59KiB. I don't want to overload the list.
Michal Privoznik (5): qemucapabilitiesdata: Add qemu-1.2.2 data qemucapabilitiesdata: Add qemu-1.3.1 data qemucapabilitiesdata: Add qemu-1.4.2 data qemucapabilitiesdata: Add qemu-1.6.0 data qemucapabilitiesdata: Add qemu-1.6.50 data
ACK series.
Does 1.6.50 make sense? That's QEMU upstream master. -- Doug Goldstein
On 07.10.2013 00:14, Doug Goldstein wrote:
On Thu, Oct 3, 2013 at 9:12 AM, Eric Blake <eblake@redhat.com> wrote:
On 10/03/2013 07:25 AM, Michal Privoznik wrote:
The actual patches are accessible at:
git://gitorious.org/libvirt/michal-staging.git
branch test_qemu_capabilities_data
I'm not sending the actual patches as it's big junk of JSON qemu replies. The patches has from 35KiB to 59KiB. I don't want to overload the list.
Michal Privoznik (5): qemucapabilitiesdata: Add qemu-1.2.2 data qemucapabilitiesdata: Add qemu-1.3.1 data qemucapabilitiesdata: Add qemu-1.4.2 data qemucapabilitiesdata: Add qemu-1.6.0 data qemucapabilitiesdata: Add qemu-1.6.50 data
ACK series.
Does 1.6.50 make sense? That's QEMU upstream master.
In my opinion it does. As I stated somewhere, there is no relationship between qemu version and its capabilities, since capabilities can be turned on or off by passing some arguments to the ./configure script. Hence the data files have this suffix (-1, -2, ..) which should differentiate between such cases. IOW - the test just checks if our capabilities code isn't broken. We can look at the version field as bare file name. Michal
On 10/03/2013 07:25 AM, Michal Privoznik wrote:
The actual patches are accessible at:
git://gitorious.org/libvirt/michal-staging.git
branch test_qemu_capabilities_data
I'm not sending the actual patches as it's big junk of JSON qemu replies. The patches has from 35KiB to 59KiB. I don't want to overload the list.
While trying to backport this series, I noticed that:
tests/qemucapabilitiesdata/caps_1.2.2-1.caps | 114 + tests/qemucapabilitiesdata/caps_1.2.2-1.replies | 1543 +++++++++++++
these .replies files are very hard to modify, when using a newer or older version of libvirt that issues more or fewer JSON commands (that is, the replies file is hardcoded to giving answers in the same order as libvirt asks questions, but if the set or order of questions changes, it's hard to see which answer(s) needs changing). I would suggest that we update the files to add a comment describing the JSON command issued prior to each reply; the test should filter out the comments. Doing this will make it easier to modify the .replies files in the future if we tweak qemu_capabilities.c to trigger more JSON commands even for older qemu responses. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
participants (3)
-
Doug Goldstein -
Eric Blake -
Michal Privoznik