[libvirt] [PATCH] Fix segfault if virtual network has no bridge listed
The attached patch fixes a libvirtd segfault if we try to call virNetworkGetBridgeName on a virtual network with no bridge in its xml. This occurs if the network hasn't been started as long as the daemon has been running. This patch also cleans up an error path in qemu_conf which was overwriting the error returned by virNetworkGetBridgeName. Thanks, Cole
On Tue, Dec 09, 2008 at 01:50:33PM -0500, Cole Robinson wrote:
The attached patch fixes a libvirtd segfault if we try to call virNetworkGetBridgeName on a virtual network with no bridge in its xml. This occurs if the network hasn't been started as long as the daemon has been running.
This patch also cleans up an error path in qemu_conf which was overwriting the error returned by virNetworkGetBridgeName.
Looks fine to me, +1 Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
Daniel Veillard wrote:
On Tue, Dec 09, 2008 at 01:50:33PM -0500, Cole Robinson wrote:
The attached patch fixes a libvirtd segfault if we try to call virNetworkGetBridgeName on a virtual network with no bridge in its xml. This occurs if the network hasn't been started as long as the daemon has been running.
This patch also cleans up an error path in qemu_conf which was overwriting the error returned by virNetworkGetBridgeName.
Looks fine to me, +1
Daniel
Thanks, applied now. - Cole
participants (2)
-
Cole Robinson -
Daniel Veillard