[Libvir] [PATCH] Fix detach-disk command for tap device
The detach-disk command does not work for tap device, since xenStoreDomainGetDiskID is always searching for vbd device from XenStore. c.f. This is a the related patch: http://git.et.redhat.com/?p=libvirt.git;a=commit;h=d27506d3a36e12b977f6a896b... So, I changed the searching path to both vbd and tap. Regards, Saori Fukuta
Saori Fukuta wrote:
The detach-disk command does not work for tap device, since xenStoreDomainGetDiskID is always searching for vbd device from XenStore. c.f. This is a the related patch: http://git.et.redhat.com/?p=libvirt.git;a=commit;h=d27506d3a36e12b977f6a896b...
So, I changed the searching path to both vbd and tap.
+1 from me. If no one else objects I'll commit it next week. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903
On Fri, Dec 14, 2007 at 10:21:54AM +0000, Richard W.M. Jones wrote:
Saori Fukuta wrote:
The detach-disk command does not work for tap device, since xenStoreDomainGetDiskID is always searching for vbd device from XenStore. c.f. This is a the related patch: http://git.et.redhat.com/?p=libvirt.git;a=commit;h=d27506d3a36e12b977f6a896b...
So, I changed the searching path to both vbd and tap.
+1 from me. If no one else objects I'll commit it next week.
ACK, no problem. I really wish I had paid more attention when tap went upstream so XenD didn't have this insanity :-( Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
On Fri, Dec 14, 2007 at 02:32:53PM +0000, Daniel P. Berrange wrote:
On Fri, Dec 14, 2007 at 10:21:54AM +0000, Richard W.M. Jones wrote:
Saori Fukuta wrote:
The detach-disk command does not work for tap device, since xenStoreDomainGetDiskID is always searching for vbd device from XenStore. c.f. This is a the related patch: http://git.et.redhat.com/?p=libvirt.git;a=commit;h=d27506d3a36e12b977f6a896b...
So, I changed the searching path to both vbd and tap.
+1 from me. If no one else objects I'll commit it next week.
ACK, no problem. I really wish I had paid more attention when tap went upstream so XenD didn't have this insanity :-(
Commited, thanks ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
participants (4)
-
Daniel P. Berrange -
Daniel Veillard -
Richard W.M. Jones -
Saori Fukuta