[libvirt] [PATCH] [libvirt-tck] Fix expected error code

Attempting to set a transient domain autostart results in ERR_OPERATION_INVALID not ERR_INTERNAL_ERROR. --- scripts/domain/051-transient-autostart.t | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/domain/051-transient-autostart.t b/scripts/domain/051-transient-autostart.t index 3e5ea61..26ca82b 100644 --- a/scripts/domain/051-transient-autostart.t +++ b/scripts/domain/051-transient-autostart.t @@ -48,7 +48,7 @@ my $auto = $dom->get_autostart(); ok(!$auto, "autostart is disabled for transient VMs"); -ok_error(sub { $dom->set_autostart(1) }, "Set autostart not supported on transient VMs", Sys::Virt::Error::ERR_INTERNAL_ERROR); +ok_error(sub { $dom->set_autostart(1) }, "Set autostart not supported on transient VMs", Sys::Virt::Error::ERR_OPERATION_INVALID); diag "Destroying the transient domain"; $dom->destroy; -- 1.7.3.1

On 02/16/2011 07:34 PM, Jim Fehlig wrote:
Attempting to set a transient domain autostart results in ERR_OPERATION_INVALID not ERR_INTERNAL_ERROR. --- scripts/domain/051-transient-autostart.t | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/domain/051-transient-autostart.t b/scripts/domain/051-transient-autostart.t index 3e5ea61..26ca82b 100644 --- a/scripts/domain/051-transient-autostart.t +++ b/scripts/domain/051-transient-autostart.t @@ -48,7 +48,7 @@ my $auto = $dom->get_autostart();
ok(!$auto, "autostart is disabled for transient VMs");
-ok_error(sub { $dom->set_autostart(1) }, "Set autostart not supported on transient VMs", Sys::Virt::Error::ERR_INTERNAL_ERROR); +ok_error(sub { $dom->set_autostart(1) }, "Set autostart not supported on transient VMs", Sys::Virt::Error::ERR_OPERATION_INVALID);
ACK. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org

Eric Blake wrote:
On 02/16/2011 07:34 PM, Jim Fehlig wrote:
Attempting to set a transient domain autostart results in ERR_OPERATION_INVALID not ERR_INTERNAL_ERROR. --- scripts/domain/051-transient-autostart.t | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/domain/051-transient-autostart.t b/scripts/domain/051-transient-autostart.t index 3e5ea61..26ca82b 100644 --- a/scripts/domain/051-transient-autostart.t +++ b/scripts/domain/051-transient-autostart.t @@ -48,7 +48,7 @@ my $auto = $dom->get_autostart();
ok(!$auto, "autostart is disabled for transient VMs");
-ok_error(sub { $dom->set_autostart(1) }, "Set autostart not supported on transient VMs", Sys::Virt::Error::ERR_INTERNAL_ERROR); +ok_error(sub { $dom->set_autostart(1) }, "Set autostart not supported on transient VMs", Sys::Virt::Error::ERR_OPERATION_INVALID);
ACK.
Thanks; pushed.
participants (2)
-
Eric Blake
-
Jim Fehlig