[libvirt PATCH v2] ci: Use openSUSE image for code style checking
CentOS does not have the cppi package, so some code style checks are skipped. Switch to a openSUSE image to do the code style checks. Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com> --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index bfb66a652d..5fbc82b3dc 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -496,7 +496,7 @@ website: codestyle: stage: builds - image: $CI_REGISTRY_IMAGE/ci-centos-8:latest + image: $CI_REGISTRY_IMAGE/ci-opensuse-151:latest before_script: - *script_variables script: -- 2.21.3
On Mon, 2020-06-22 at 09:43 -0500, Jonathon Jongsma wrote:
CentOS does not have the cppi package, so some code style checks are skipped. Switch to a openSUSE image to do the code style checks.
Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com> --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Andrea Bolognani <abologna@redhat.com> -- Andrea Bolognani / Red Hat / Virtualization
On Mon, 2020-06-22 at 18:18 +0200, Andrea Bolognani wrote:
On Mon, 2020-06-22 at 09:43 -0500, Jonathon Jongsma wrote:
CentOS does not have the cppi package, so some code style checks are skipped. Switch to a openSUSE image to do the code style checks.
Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com> --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
Not that it's a particularly important patch, but I just thought I'd mention that if we do want it upstream, I'll need somebody to push it for me ;) Jonathon
On Thu, Jun 25, 2020 at 03:43:37PM -0500, Jonathon Jongsma wrote:
On Mon, 2020-06-22 at 18:18 +0200, Andrea Bolognani wrote:
On Mon, 2020-06-22 at 09:43 -0500, Jonathon Jongsma wrote:
CentOS does not have the cppi package, so some code style checks are skipped. Switch to a openSUSE image to do the code style checks.
Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com> --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
Not that it's a particularly important patch, but I just thought I'd mention that if we do want it upstream, I'll need somebody to push it for me ;)
Reviewed-by: Erik Skultety <eskultet@redhat.com> and pushed. Regards, Erik
participants (3)
-
Andrea Bolognani -
Erik Skultety -
Jonathon Jongsma