The openvz driver currrently generates a compile warning due to this unused function. If no one objects I'll shortly remove it. I intend to turn on openvz and LXC driver compilation for the nightly builds to get more testing coverage Daniel diff -r 59140de4e7a9 src/openvz_driver.c --- a/src/openvz_driver.c Mon Jul 21 18:27:29 2008 +0100 +++ b/src/openvz_driver.c Tue Jul 22 22:12:22 2008 +0100 @@ -91,32 +91,11 @@ unsigned int flags ATTRIBUTE_UNUSED); static int openvzDomainUndefine(virDomainPtr dom); -static int convCmdbufExec(char cmdbuf[], char *cmdExec[]); static void cmdExecFree(char *cmdExec[]); static int openvzGetProcessInfo(unsigned long long *cpuTime, int vpsid); struct openvz_driver ovz_driver; - -static int convCmdbufExec(char cmdbuf[], char *cmdExec[]) -{ - int i=0, limit = OPENVZ_MAX_ARG - 1; - char cmdWord[CMDOP_LEN]; - while(*cmdbuf) - { - if(i >= limit) - { - cmdExec[i] = NULL; - return -1; - } - sscanf(cmdbuf, "%s", cmdWord); - cmdbuf += strlen(cmdWord); - while(*cmdbuf == ' ') cmdbuf++; - cmdExec[i++] = strdup(cmdWord); - } - cmdExec[i] = NULL; - return i; -} static void cmdExecFree(char *cmdExec[]) { -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|