[libvirt] [PATCH] libvirt-guests: Run only after libvirtd (bug 906009)

Possible fix for occasional libvirt-guests failure at boot time. --- tools/libvirt-guests.service.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libvirt-guests.service.in b/tools/libvirt-guests.service.in index d41bf2b..8153418 100644 --- a/tools/libvirt-guests.service.in +++ b/tools/libvirt-guests.service.in @@ -1,6 +1,6 @@ [Unit] Description=Suspend Active Libvirt Guests -After=syslog.target network.target +After=syslog.target network.target libvirtd.service [Service] EnvironmentFile=-/etc/sysconfig/libvirt-guests -- 1.8.4.2

On 11/19/2013 01:22 PM, Cole Robinson wrote:
Possible fix for occasional libvirt-guests failure at boot time. --- tools/libvirt-guests.service.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libvirt-guests.service.in b/tools/libvirt-guests.service.in index d41bf2b..8153418 100644 --- a/tools/libvirt-guests.service.in +++ b/tools/libvirt-guests.service.in @@ -1,6 +1,6 @@ [Unit] Description=Suspend Active Libvirt Guests -After=syslog.target network.target +After=syslog.target network.target libvirtd.service
Worth mentioning the BZ in the commit message https://bugzilla.redhat.com/show_bug.cgi?id=906009 and based on Guido's patch for libvirtd.service, we should also use this opportunity to drop syslog.target. But makes sense to me. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org

On 11/19/2013 03:27 PM, Eric Blake wrote:
On 11/19/2013 01:22 PM, Cole Robinson wrote:
Possible fix for occasional libvirt-guests failure at boot time. --- tools/libvirt-guests.service.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libvirt-guests.service.in b/tools/libvirt-guests.service.in index d41bf2b..8153418 100644 --- a/tools/libvirt-guests.service.in +++ b/tools/libvirt-guests.service.in @@ -1,6 +1,6 @@ [Unit] Description=Suspend Active Libvirt Guests -After=syslog.target network.target +After=syslog.target network.target libvirtd.service
Worth mentioning the BZ in the commit message https://bugzilla.redhat.com/show_bug.cgi?id=906009
It's in the subject (and hence the commit message), but indeed full link format is friendlier.
and based on Guido's patch for libvirtd.service, we should also use this opportunity to drop syslog.target.
Guido's patch touches libvirt-guests as well.
But makes sense to me.
Thanks, I'll push after Guido's patch goes in. - Cole

On 11/19/2013 03:29 PM, Cole Robinson wrote:
On 11/19/2013 03:27 PM, Eric Blake wrote:
On 11/19/2013 01:22 PM, Cole Robinson wrote:
Possible fix for occasional libvirt-guests failure at boot time. --- tools/libvirt-guests.service.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libvirt-guests.service.in b/tools/libvirt-guests.service.in index d41bf2b..8153418 100644 --- a/tools/libvirt-guests.service.in +++ b/tools/libvirt-guests.service.in @@ -1,6 +1,6 @@ [Unit] Description=Suspend Active Libvirt Guests -After=syslog.target network.target +After=syslog.target network.target libvirtd.service
Worth mentioning the BZ in the commit message https://bugzilla.redhat.com/show_bug.cgi?id=906009
It's in the subject (and hence the commit message), but indeed full link format is friendlier.
and based on Guido's patch for libvirtd.service, we should also use this opportunity to drop syslog.target.
Guido's patch touches libvirt-guests as well.
But makes sense to me.
Thanks, I'll push after Guido's patch goes in.
Pushed now. - Cole
participants (2)
-
Cole Robinson
-
Eric Blake