[libvirt] [PATCH] Disable netcf if building without libvirtd

From: "Daniel P. Berrange" <berrange@redhat.com> Although the netcf interface driver can in theory be used by the stateless drivers, in practice none of them want to use it because they have different ways of dealing with interfaces. Furthermore, if you have mingw32-netcf installed, then the libvirt mingw32 build will fail with ../../src/interface/netcf_driver.c:644:5: error: unknown field 'close_used_without_including_unistd_h' specified in initializer * configure.ac: disable netcf if built without libvirtd --- configure.ac | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index b12e9fb..729ba9b 100644 --- a/configure.ac +++ b/configure.ac @@ -1613,6 +1613,9 @@ AC_ARG_WITH([netcf], NETCF_CFLAGS= NETCF_LIBS= +if test "$with_libvirtd" = "no" ; then + with_netcf=no +fi if test "$with_netcf" = "yes" || test "$with_netcf" = "check"; then PKG_CHECK_MODULES(NETCF, netcf >= $NETCF_REQUIRED, [with_netcf=yes], [ -- 1.7.7.5

On 01/11/2012 07:11 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange@redhat.com>
Although the netcf interface driver can in theory be used by the stateless drivers, in practice none of them want to use it because they have different ways of dealing with interfaces.
Furthermore, if you have mingw32-netcf installed, then the libvirt mingw32 build will fail with
../../src/interface/netcf_driver.c:644:5: error: unknown field 'close_used_without_including_unistd_h' specified in initializer
* configure.ac: disable netcf if built without libvirtd --- configure.ac | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
ACK. Funny how we both fixed the same compilation problem in netcf_driver.c by adding a minor change in a completely different file, but I agree that both fixes are worth applying. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
participants (2)
-
Daniel P. Berrange
-
Eric Blake