[libvirt] [PATCH] cpu: Fix definition of flag smap

A mild case of dyslexia caused that commit 012f9b19ef3812884e207dc431571502de4cebce specifies wrong mask for the smap cpu feature flag. This patch fixes that mistake. --- The flags definition file in qemu can be accessed at: http://git.qemu.org/?p=qemu.git;a=blob;f=target-i386/cpu.c;h=f3708e63b76541b... --- src/cpu/cpu_map.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml index d059e20..f0a1f04 100644 --- a/src/cpu/cpu_map.xml +++ b/src/cpu/cpu_map.xml @@ -270,7 +270,7 @@ <cpuid function='0x00000007' ebx='0x00000080'/> </feature> <feature name='smap'> - <cpuid function='0x00000007' ebx='0x00080000'/> + <cpuid function='0x00000007' ebx='0x00100000'/> </feature> <!-- models --> -- 1.7.12.4

On 10/30/2012 08:07 AM, Peter Krempa wrote:
A mild case of dyslexia caused that commit 012f9b19ef3812884e207dc431571502de4cebce specifies wrong mask for the smap cpu feature flag. This patch fixes that mistake. --- The flags definition file in qemu can be accessed at: http://git.qemu.org/?p=qemu.git;a=blob;f=target-i386/cpu.c;h=f3708e63b76541b...
Very helpful link, although #l40 was a bit far from #l110 where "smap" actually appears. ACK. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org

On 10/30/12 16:41, Eric Blake wrote:
On 10/30/2012 08:07 AM, Peter Krempa wrote:
A mild case of dyslexia caused that commit 012f9b19ef3812884e207dc431571502de4cebce specifies wrong mask for the smap cpu feature flag. This patch fixes that mistake. --- The flags definition file in qemu can be accessed at: http://git.qemu.org/?p=qemu.git;a=blob;f=target-i386/cpu.c;h=f3708e63b76541b...
Very helpful link, although #l40 was a bit far from #l110 where "smap" actually appears.
OOps, I stole the link from the flawed patch and didn't check :)
ACK.
Thanks; pushed Peter
participants (2)
-
Eric Blake
-
Peter Krempa