Hi sorry for the delay in responding. Regarding the intel email footer, I understand that It might deter people from responding. it is automatically added if I email an external address by our exchange server. I have asked for my account to be added to the exception whitelist so this should be removed soon. If not I will follow up with my personal email account. Regarding abstracting the implementation to a separate file, if the changes are small enough Perhaps the new code can be added util/virpci and util/virhostdev instead of creating util/virinterupt I can refactor the implementation to reflect whichever is preferred during code review. I would prefer to use auto as the default also. If the consensus is that it would be better not to enable this feature by default, then I am happy to do that too. I agree that the final implementation should also handle changes in the vm configuration (vpus, hostdevs plug/unplugged) and changes In the vm power state also. Regards Sean -----Original Message----- From: Martin Kletzander [mailto:mkletzan@redhat.com] Sent: Monday, August 25, 2014 11:35 AM To: Mooney, Sean K Cc: libvir-list(a)redhat.com Subject: Re: [libvirt] Automatically affinitize hostdev interrupts to vm vCpus (qemu/kvm) On Mon, Aug 18, 2014 at 07:01:40PM +0000, Mooney, Sean K wrote: Hi, could you convince your e-mail agent to wrap long lines? Nice that this will be abstracted out in a separate file, although if it's not huge, it can be part of something else. So it will only affect hostdevs, OK, that means there should be less (or no) disadvantages). Although beware that hostdevs can be plugged/unplugged, number of vCPUs can be changed and, most importantly, the affinities (either set with sched_set_affinity or using cgroups) can be changed during the lifetime of the VM, and the smp_affinity of each IRQ should track such changes. Needless to say the affinity should be restored after the machine dies/is turned off, etc., not just on hostdev unplug. I like defaulting to auto also because the transparent use will have effect only in existing deployments with vCPU pinning. Although this version might be preferred by others. This can, however, be discussed (and changed) during reviews. Since this mailing-list is public and archived, such disclaimer is unenforceable. As an upstream project, the development is done in the open. Such statements as the above one may be the cause of nobody replying for some time to your e-mail. The statement itself can be understood that even delivering the mail through a list is prohibited. Please consider removing such statements in following e-mails (or use private e-mail address if the disclaimer is enforced by your employer) as keeping them may result in the rest of the community not being able to communicate with you. Martin -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.