[libvirt PATCH v2 0/2] rST-ify and rewrite a couple of block-layer docs

I don't think the Debian "sid" failure is related to my patch: https://gitlab.com/kashyapc/libvirt/-/pipelines/300380749/failures Changes in v2: - Mention backupBegin() [Peter] - Add examples of push-mode backup using backupBegin() [Peter, Kashyap] - Use existing rST conventions to make `rst2html5` happy [Michal] - Update meson.build [Michal] - Use .contents:: [Michal] - Paragraph alignment [Michal] Kashyap Chamarthy (2): docs: kbase: Add a doc on live full disk backup docs: kbase: Add a doc on merging disk image chains docs/kbase/live_full_disk_backup.rst | 186 +++++++++++++++++++++ docs/kbase/merging_disk_image_chains.rst | 200 +++++++++++++++++++++++ docs/kbase/meson.build | 2 + 3 files changed, 388 insertions(+) create mode 100644 docs/kbase/live_full_disk_backup.rst create mode 100644 docs/kbase/merging_disk_image_chains.rst -- 2.30.2

This is a rewrite of: https://wiki.libvirt.org/page/Live-disk-backup-with-active-blockcommit Once this commit merges, the above wiki should point to this kbase document. NB: I've intentionally left out the example for pull-based full backups. I'll tackle it once QMP `x-blockdev-reopen` comes out of experimental mode in upstream QEMU. Then pull-based can be described for both full and and differntial backups. Overall, future documents should cover: - full backups using both push- and pull-mode - differential backups using both push- and pull-mode Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com> --- docs/kbase/live_full_disk_backup.rst | 186 +++++++++++++++++++++++++++ docs/kbase/meson.build | 1 + 2 files changed, 187 insertions(+) create mode 100644 docs/kbase/live_full_disk_backup.rst diff --git a/docs/kbase/live_full_disk_backup.rst b/docs/kbase/live_full_disk_backup.rst new file mode 100644 index 0000000000..19f027daac --- /dev/null +++ b/docs/kbase/live_full_disk_backup.rst @@ -0,0 +1,186 @@ +=============================== +Efficient live full disk backup +=============================== + +.. contents:: + +Overview +======== + +Live full disk backups are preferred in many scenarios, *despite* their +space requirements. The following outlines an efficient method to do +that using libvirt's APIs. This method involves concepts: the notion of +`backing chains <https://libvirt.org/kbase/backing_chains.html>`_, +`QCOW2 overlays +<https://qemu.readthedocs.io/en/latest/interop/live-block-operations.html#disk-image-backing-chain-notation>`_, +and a special operation called "active block-commit", which allows +live-merging an overlay disk image into its backing file. + +Two kinds of backup: "push" and "pull" +====================================== + +QEMU and libvirt combine the concept of `bitmaps +<https://qemu-project.gitlab.io/qemu/interop/bitmaps.html>`_ and network +block device (NBD) to allow copying out modified data blocks. There are +two approaches to it: In the first, "push mode", when a user requests +for it, libvirt creates a full backup in an external location (i.e. +libvirt "pushes" the data to the target). + +In the other, "pull mode", libvirt (in coordination with QEMU) exposes +the data that needs to be written out and allows a third-party tool to +copy them out reliably (i.e. the data is being "pulled" from libvirt). +The pull-based backup provides more flexibility by letting an external +tool fetch the modified bits as it sees fit, rather than waiting on +libvirt to push out a full backup to a target location. + +The push- and pull-mode techniques also apply for differential backups +(it also includes incremental backups), which track what has changed +since *any* given backup. + +This document covers only the full backups using the the "push" mode. + + +Full disk backup using "push" mode +================================== + +The below approach uses the modern backup API, virDomainBackupBegin(). +This requires libvirt-7.2.0 and QEMU-4.2, or higher versions. + +#. Start the guest:: + + $> virsh start vm1 + Domain 'vm1' started + +#. Enumerate the disk(s) in use:: + + $> virsh domblklist vm1 + Target Source + -------------------------------------- + vda /var/lib/libvirt/images/vm1.qcow2 + +#. Begin the backup:: + + $> virsh backup-begin vm1 + Backup started + +#. Check the job status ("None" means the job has likely completed):: + + $> virsh domjobinfo vm1 + Job type: None + +#. Check the completed job status:: + + $> virsh domjobinfo vm1 --completed + Job type: Completed + Operation: Backup + Time elapsed: 183 ms + File processed: 39.250 MiB + File remaining: 0.000 B + File total: 39.250 MiB + +#. Now we see the copy of the backup:: + + $> ls -lash /var/lib/libvirt/images/vm1.qcow2* + 15M -rw-r--r--. 1 qemu qemu 15M May 10 12:22 vm1.qcow2 + 21M -rw-------. 1 root root 21M May 10 12:23 vm1.qcow2.1620642185 + + +Full backup with older libvirt versions +======================================= + +This is the alternative in case you cannot use libvirt-7.2.0 and +QEMU-4.2 for some reason. But this assumes you're using *at least* QEMU +2.1 and libvirt-1.2.9. + +This backup approach is slightly more involved, and predates the +virDomainBackupBegin() API: Assuming a guest with a single disk image, +create a temporary live QCOW2 overlay (commonly called as "external +snapshot") to track the live guest writes. Then backup the original +disk image while the guest (live QEMU) keeps writing to the temporary +overlay. Finally, perform the "active block-commit" opertion to +live-merge the temporary overlay disk contents into the original image — +i.e. the backing file — and "pivot" the live QEMU process to point to +it. + + +#. Start with a guest with a single disk image, ``base.raw``, which is + where the live QEMU is pointing at, and recording the guest writes:: + + base.raw (live QEMU) + +#. List the current block device(s) in use:: + + $ virsh domblklist vm1 + Target Source + ------------------------------------------------ + vda /var/lib/libvirt/images/base.raw + +#. Create the live "external disk snapshot" (or more correctly, "an + overlay"):: + + $ virsh snapshot-create-as --domain vm1 overlay1 \ + --diskspec vda,file=/var/lib/libvirt/images/overlay1.qcow2 \ + --disk-only + + The disk image chain looks as follows:: + + base.raw <-- overlay1.qcow2 (live QEMU) + + .. note:: + Above, if you have QEMU guest agent installed in your virtual + machine, use the ``--quiesce`` option with ``virsh + snapshot-create-as [...]`` to ensure you have a consistent disk + state. + + Optionally, you can also supply the ``--no-metadata`` option to + ``virsh snapshot-create-as`` to tell libvirt not track the snapshot + metadata. Otherwise, when you decide to merge snapshot overlays, + you have to explicitly clean the libvirt metadata using ``virsh + snapshot-delete vm1 --metadata [name|--current]``. + +#. Now, take a backup the orignal image, ``base.raw``, to a different + location using ``cp`` or ``rsync``:: + + $ cp /var/lib/libvirt/images/base.raw + /export/backups/copy1_base.raw + + # Or: + + $ rsync -avhW --progress /var/lib/libvirt/images/base.raw \ + /export/backups/copy1_base.raw + +#. Enumerate the current block device(s) in use, again. Notice that the + current disk image in use is the above-created overlay, + ``overlay1.qcow2``:: + + $ virsh domblklist vm1 + Target Source + ------------------------------------------------ + vda vda,file=/var/lib/libvirt/images/overlay1.qcow2 + +#. Once the backup of the original image completes, now perform the + "active block-commit" to live-merge the contents of + ``overlay1.qcow2`` into ``base.raw`` *and* pivot the live QEMU back + to the original:: + + $ virsh blockcommit vm1 vda --active --verbose --pivot + +#. After the above operation completes, again list the current block + device(s) in use. And notice that the live QEMU is now writing to + the original base image:: + + $ virsh domblklist vm1 + Target Source + ------------------------------------------------ + vda /var/lib/libvirt/images/base.raw + + +The final updated disk image "chain" will be a single consolidated +disk:: + + [base.raw] (live QEMU) + + +Now you can safely **discard the overlay image**, ``overlay1.qcow2`` — +it is no longer valid; and its contents are now fully merged into the +base image. diff --git a/docs/kbase/meson.build b/docs/kbase/meson.build index 7b4e7abbd3..51d4bc7b90 100644 --- a/docs/kbase/meson.build +++ b/docs/kbase/meson.build @@ -6,6 +6,7 @@ docs_kbase_files = [ 'index', 'kvm-realtime', 'launch_security_sev', + 'live_full_disk_backup', 'locking-lockd', 'locking', 'locking-sanlock', -- 2.30.2

On 5/10/21 6:39 PM, Kashyap Chamarthy wrote:
This is a rewrite of:
https://wiki.libvirt.org/page/Live-disk-backup-with-active-blockcommit
Once this commit merges, the above wiki should point to this kbase document.
NB: I've intentionally left out the example for pull-based full backups. I'll tackle it once QMP `x-blockdev-reopen` comes out of experimental mode in upstream QEMU. Then pull-based can be described for both full and and differntial backups.
Overall, future documents should cover:
- full backups using both push- and pull-mode - differential backups using both push- and pull-mode
Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com> --- docs/kbase/live_full_disk_backup.rst | 186 +++++++++++++++++++++++++++ docs/kbase/meson.build | 1 + 2 files changed, 187 insertions(+) create mode 100644 docs/kbase/live_full_disk_backup.rst
diff --git a/docs/kbase/live_full_disk_backup.rst b/docs/kbase/live_full_disk_backup.rst new file mode 100644 index 0000000000..19f027daac --- /dev/null +++ b/docs/kbase/live_full_disk_backup.rst @@ -0,0 +1,186 @@ +=============================== +Efficient live full disk backup +=============================== + +.. contents:: + +Overview +======== + +Live full disk backups are preferred in many scenarios, *despite* their +space requirements. The following outlines an efficient method to do +that using libvirt's APIs. This method involves concepts: the notion of +`backing chains <https://libvirt.org/kbase/backing_chains.html>`_, +`QCOW2 overlays +<https://qemu.readthedocs.io/en/latest/interop/live-block-operations.html#disk-image-backing-chain-notation>`_, +and a special operation called "active block-commit", which allows +live-merging an overlay disk image into its backing file. + +Two kinds of backup: "push" and "pull" +====================================== + +QEMU and libvirt combine the concept of `bitmaps +<https://qemu-project.gitlab.io/qemu/interop/bitmaps.html>`_ and network +block device (NBD) to allow copying out modified data blocks. There are +two approaches to it: In the first, "push mode", when a user requests +for it, libvirt creates a full backup in an external location (i.e. +libvirt "pushes" the data to the target). + +In the other, "pull mode", libvirt (in coordination with QEMU) exposes +the data that needs to be written out and allows a third-party tool to +copy them out reliably (i.e. the data is being "pulled" from libvirt). +The pull-based backup provides more flexibility by letting an external +tool fetch the modified bits as it sees fit, rather than waiting on +libvirt to push out a full backup to a target location. + +The push- and pull-mode techniques also apply for differential backups +(it also includes incremental backups), which track what has changed +since *any* given backup. + +This document covers only the full backups using the the "push" mode.
s/the the/the/ I'm surprised that 'ninja test' did not catch it. And it can also be seen in the pipeline output you link in cover letter - if you know where to look because it's way too verbose. Michal

This is a rewrite of: https://wiki.libvirt.org/page/Live-merge-an-entire-disk-image-chain-includin... Once this commit merges, the above wiki should point to this kbase document. Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com> --- docs/kbase/merging_disk_image_chains.rst | 200 +++++++++++++++++++++++ docs/kbase/meson.build | 1 + 2 files changed, 201 insertions(+) create mode 100644 docs/kbase/merging_disk_image_chains.rst diff --git a/docs/kbase/merging_disk_image_chains.rst b/docs/kbase/merging_disk_image_chains.rst new file mode 100644 index 0000000000..7635bd3eec --- /dev/null +++ b/docs/kbase/merging_disk_image_chains.rst @@ -0,0 +1,200 @@ +=============================== +Merging disk image image chains +=============================== + +.. contents:: + +Context +======= + +Sometimes a `disk image chain +<https://libvirt.org/kbase/backing_chains.html>`_ can get long and +cumbersome. For the purpose of illustration, consider this smaller disk +image chain:: + + base.raw <-- a.qcow2 <-- b.qcow2 <-- c.qcow2 (live QEMU) + +You may want to reduce the backing chain length, or consolidate *all* +the disk images in the chain into a single image. But you want to +accomplish this *without* incurring guest down time. Here's how to go +about it. + +The same principles used in the `live full disk backup +<https://libvirt.org/kbase/live_full_disk_backup.html>` document are +used here too. + +Reducing the disk image chain length +==================================== + +Starting the earlier image chain:: + + base.raw <-- a.qcow2 <-- b.qcow2 <-- c.qcow2 (live QEMU) + +Reduce the length of the chain by two images, with the resulting chain +being:: + + base.raw <-- c.qcow2 (live QEMU) + +Where the ``base.raw`` contains the contents of ``a.qcow2`` and +``b.qcow2``. + +#. Start by listing the current active disk image in use:: + + $ virsh domblklist vm1 + Target Source + ------------------------------------------------ + vda /var/lib/libvirt/images/base.raw + +#. Create the image chain by creating three QCOW2 overlays (or "external + snapshots") on top of each other, while adding some differentiating + content in each image:: + + $ virsh snapshot-create-as --domain vm1 snap1 \ + --diskspec vda,file=/var/lib/libvirt/images/a.qcow2 \ + --disk-only --no-metadata + + # <Add a file in the guest> + + $ virsh snapshot-create-as --domain vm1 snap2 \ + --diskspec vda,file=/var/lib/libvirt/images/b.qcow2 \ + --disk-only --no-metadata + + # <Add another file in the guest> + + $ virsh snapshot-create-as --domain vm1 snap3 \ + --diskspec vda,file=/var/lib/libvirt/images/c.qcow2 \ + --disk-only --no-metadata + +#. Enumerate the backing file chain (here the ``force-share`` option + simply allows ``qemu-img`` to safely query the disk image status + while it is active) :: + + $ qemu-img info --force-share --backing-chain /var/lib/libvirt/images/cur.qcow2 + [...] + +#. Again, list the current active disk image in use:: + + $ virsh domblklist vm1 + Target Source + ------------------------------------------------ + vda /var/lib/libvirt/images/c.qcow2 + +#. Perform the "block-commit" by specify the "base" and "top" images, + i.e. merge the contents of ``b.qcow2`` *and* ``a.qcow2`` into + ``base.raw``, *and* :: + + $ virsh blockcommit vm1 vda \ + --base=/var/lib/libvirt/images/base.raw + --top=/var/lib/libvirt/images/b.qcow2 + +A note on accessing 'base' and 'top' images +------------------------------------------- + +Specifying file paths, as above, make sense when your disks are in the +local filesystem. However, when using more complicated setups such as +network block device (NBD) disks, there are no file paths. Hhere is +where accessing the disk by its index number comes into picture. + +As an example, the below is the ``<disk>`` element of the guest XML for +with the original disk image chain of four images:: + + ... + <disk type='file' device='disk'> + <driver name='qemu' type='qcow2'/> + <source file='/var/lib/libvirt/images/c.qcow2' index='4'/> + <backingStore type='file' index='3'> + <format type='qcow2'/> + <source file='/var/lib/libvirt/images/b.qcow2'/> + <backingStore type='file' index='2'> + <format type='qcow2'/> + <source file='/var/lib/libvirt/images/a.qcow2'/> + <backingStore type='file' index='1'> + <format type='raw'/> + <source file='/var/lib/libvirt/images/base.raw'/> + <backingStore/> + </backingStore> + </backingStore> + </backingStore> + <target dev='vda' bus='virtio'/> + <alias name='virtio-disk0'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/> + </disk> + ... + +And we can merge the images ``a.qcow2`` and ``b.qcow2`` into +``base.qcow2`` using the index numbers 1 (for ``base.qcow2``) and :: + + $> virsh blockcommit vm1 vda --base='vda[1]' --top='vda[3]' + +Note that the shell quoting is necessary here, since unquoted ``[1]`` +would do an unexpected shell "globbing" (i.e. file name expansion) if +you have a file '1' in the current directory + +Accessing the disk images via their index numbers is more useful when +you're using blockCommit() API programmatically. + + +Consolidating an entire disk image chain into a single image +============================================================ + +Again, starting the original image chain:: + + base.raw <-- a.qcow2 <-- b.qcow2 <-- c.qcow2 (live QEMU) + +Reduce the length of the chain by two images, with the resulting chain +being:: + + base.raw (live QEMU) + +Where the ``base.raw`` contains the contents of ``a.qcow2``, ``b.qcow2`` +and ``c.qcow2``; *and* the live QEMU is piovoted to point to the +``base.raw``. + + +#. Use the same procedure discussed earlier to create the disk image + chain. + + +#. Now perform the "active block-commit" operation:: + + $ virsh blockcommit vm1 vda --verbose --pivot --active + Block Commit: [100 %] + Successfully pivoted + + Notes: + + - ``--active``: It performs a two-stage operation: first, the contents + from top images (``a.qcow2``, ``b.qcow2``, and ``c.qcow2``) are + committed into the base image; and in the second stage, the the + "block-commit" operation remains awake to synchronize any further + changes from top images into base. Here the user can take two + actions: cancel the job, or pivot the job, i.e. adjust the base + image as the current active image. + + - ``--pivot``: Once data is committed from sn1, sn2 and current into + base, it pivots the live QEMU to use base as the active image. + + - ``--verbose``: It shows the progress of block operation. + + +#. Again, check the current active block device in use:: + + $ virsh domblklist vm1 + Target Source + ------------------------------------------------ + vda /var/lib/libvirt/images/base.raw + + +#. Enumerate the backing file chain:: + + $ qemu-img info --backing-chain /var/lib/libvirt/images/base.raw + [...] + + And the final resulting disk image "chain" will be a single, + consolidated disk image:: + + [base] (live QEMU) + +It is worth bearing in mind that once the above pivot completes, *all* +three overlay files — ``a.qcow2``, ``b.qcow2``, and ``c.qcow2`` — are no +longer valid, and can be safely discarded. diff --git a/docs/kbase/meson.build b/docs/kbase/meson.build index 51d4bc7b90..7631b47018 100644 --- a/docs/kbase/meson.build +++ b/docs/kbase/meson.build @@ -10,6 +10,7 @@ docs_kbase_files = [ 'locking-lockd', 'locking', 'locking-sanlock', + 'merging_disk_image_chains', 'migrationinternals', 'qemu-passthrough-security', 'rpm-deployment', -- 2.30.2

On 5/10/21 6:39 PM, Kashyap Chamarthy wrote:
This is a rewrite of:
https://wiki.libvirt.org/page/Live-merge-an-entire-disk-image-chain-includin...
Once this commit merges, the above wiki should point to this kbase document.
Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com> --- docs/kbase/merging_disk_image_chains.rst | 200 +++++++++++++++++++++++ docs/kbase/meson.build | 1 + 2 files changed, 201 insertions(+) create mode 100644 docs/kbase/merging_disk_image_chains.rst
diff --git a/docs/kbase/merging_disk_image_chains.rst b/docs/kbase/merging_disk_image_chains.rst new file mode 100644 index 0000000000..7635bd3eec --- /dev/null +++ b/docs/kbase/merging_disk_image_chains.rst @@ -0,0 +1,200 @@ +=============================== +Merging disk image image chains +=============================== + +.. contents:: + +Context +======= + +Sometimes a `disk image chain +<https://libvirt.org/kbase/backing_chains.html>`_ can get long and +cumbersome. For the purpose of illustration, consider this smaller disk +image chain:: + + base.raw <-- a.qcow2 <-- b.qcow2 <-- c.qcow2 (live QEMU) + +You may want to reduce the backing chain length, or consolidate *all* +the disk images in the chain into a single image. But you want to +accomplish this *without* incurring guest down time. Here's how to go +about it. + +The same principles used in the `live full disk backup +<https://libvirt.org/kbase/live_full_disk_backup.html>` document are +used here too. + +Reducing the disk image chain length +==================================== + +Starting the earlier image chain:: + + base.raw <-- a.qcow2 <-- b.qcow2 <-- c.qcow2 (live QEMU) + +Reduce the length of the chain by two images, with the resulting chain +being:: + + base.raw <-- c.qcow2 (live QEMU) + +Where the ``base.raw`` contains the contents of ``a.qcow2`` and +``b.qcow2``. + +#. Start by listing the current active disk image in use:: + + $ virsh domblklist vm1 + Target Source + ------------------------------------------------ + vda /var/lib/libvirt/images/base.raw + +#. Create the image chain by creating three QCOW2 overlays (or "external + snapshots") on top of each other, while adding some differentiating + content in each image:: + + $ virsh snapshot-create-as --domain vm1 snap1 \ + --diskspec vda,file=/var/lib/libvirt/images/a.qcow2 \ + --disk-only --no-metadata + + # <Add a file in the guest> + + $ virsh snapshot-create-as --domain vm1 snap2 \ + --diskspec vda,file=/var/lib/libvirt/images/b.qcow2 \ + --disk-only --no-metadata + + # <Add another file in the guest> + + $ virsh snapshot-create-as --domain vm1 snap3 \ + --diskspec vda,file=/var/lib/libvirt/images/c.qcow2 \ + --disk-only --no-metadata + +#. Enumerate the backing file chain (here the ``force-share`` option + simply allows ``qemu-img`` to safely query the disk image status + while it is active) :: + + $ qemu-img info --force-share --backing-chain /var/lib/libvirt/images/cur.qcow2 + [...] + +#. Again, list the current active disk image in use:: + + $ virsh domblklist vm1 + Target Source + ------------------------------------------------ + vda /var/lib/libvirt/images/c.qcow2 + +#. Perform the "block-commit" by specify the "base" and "top" images, + i.e. merge the contents of ``b.qcow2`` *and* ``a.qcow2`` into + ``base.raw``, *and* :: + + $ virsh blockcommit vm1 vda \ + --base=/var/lib/libvirt/images/base.raw + --top=/var/lib/libvirt/images/b.qcow2 + +A note on accessing 'base' and 'top' images +------------------------------------------- + +Specifying file paths, as above, make sense when your disks are in the +local filesystem. However, when using more complicated setups such as +network block device (NBD) disks, there are no file paths. Hhere is +where accessing the disk by its index number comes into picture. + +As an example, the below is the ``<disk>`` element of the guest XML for +with the original disk image chain of four images:: + + ... + <disk type='file' device='disk'> + <driver name='qemu' type='qcow2'/> + <source file='/var/lib/libvirt/images/c.qcow2' index='4'/> + <backingStore type='file' index='3'> + <format type='qcow2'/> + <source file='/var/lib/libvirt/images/b.qcow2'/> + <backingStore type='file' index='2'> + <format type='qcow2'/> + <source file='/var/lib/libvirt/images/a.qcow2'/> + <backingStore type='file' index='1'> + <format type='raw'/> + <source file='/var/lib/libvirt/images/base.raw'/> + <backingStore/> + </backingStore> + </backingStore> + </backingStore> + <target dev='vda' bus='virtio'/> + <alias name='virtio-disk0'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/> + </disk> + ... + +And we can merge the images ``a.qcow2`` and ``b.qcow2`` into +``base.qcow2`` using the index numbers 1 (for ``base.qcow2``) and :: + + $> virsh blockcommit vm1 vda --base='vda[1]' --top='vda[3]' + +Note that the shell quoting is necessary here, since unquoted ``[1]`` +would do an unexpected shell "globbing" (i.e. file name expansion) if +you have a file '1' in the current directory + +Accessing the disk images via their index numbers is more useful when +you're using blockCommit() API programmatically. + + +Consolidating an entire disk image chain into a single image +============================================================ + +Again, starting the original image chain:: + + base.raw <-- a.qcow2 <-- b.qcow2 <-- c.qcow2 (live QEMU) + +Reduce the length of the chain by two images, with the resulting chain +being:: + + base.raw (live QEMU) + +Where the ``base.raw`` contains the contents of ``a.qcow2``, ``b.qcow2`` +and ``c.qcow2``; *and* the live QEMU is piovoted to point to the +``base.raw``. + + +#. Use the same procedure discussed earlier to create the disk image + chain. + + +#. Now perform the "active block-commit" operation:: + + $ virsh blockcommit vm1 vda --verbose --pivot --active + Block Commit: [100 %] + Successfully pivoted + + Notes: + + - ``--active``: It performs a two-stage operation: first, the contents + from top images (``a.qcow2``, ``b.qcow2``, and ``c.qcow2``) are + committed into the base image; and in the second stage, the the
s/the the/the/ Michal

On 5/10/21 6:39 PM, Kashyap Chamarthy wrote:
I don't think the Debian "sid" failure is related to my patch:
https://gitlab.com/kashyapc/libvirt/-/pipelines/300380749/failures
Changes in v2:
- Mention backupBegin() [Peter] - Add examples of push-mode backup using backupBegin() [Peter, Kashyap] - Use existing rST conventions to make `rst2html5` happy [Michal] - Update meson.build [Michal] - Use .contents:: [Michal] - Paragraph alignment [Michal]
Kashyap Chamarthy (2): docs: kbase: Add a doc on live full disk backup docs: kbase: Add a doc on merging disk image chains
docs/kbase/live_full_disk_backup.rst | 186 +++++++++++++++++++++ docs/kbase/merging_disk_image_chains.rst | 200 +++++++++++++++++++++++ docs/kbase/meson.build | 2 + 3 files changed, 388 insertions(+) create mode 100644 docs/kbase/live_full_disk_backup.rst create mode 100644 docs/kbase/merging_disk_image_chains.rst
Patches look good and I'm inclined to merge them. Thank you for reworking v1 per our reviews. However, what I completely missed in my review of v1 is to add links from docs/kbase/index.rst to new pages you're introducing. I can fix that before push if you reply with a diff that would do just that. Michal

On Tue, May 11, 2021 at 09:54:28AM +0200, Michal Prívozník wrote:
On 5/10/21 6:39 PM, Kashyap Chamarthy wrote:
I don't think the Debian "sid" failure is related to my patch:
https://gitlab.com/kashyapc/libvirt/-/pipelines/300380749/failures
Changes in v2:
- Mention backupBegin() [Peter] - Add examples of push-mode backup using backupBegin() [Peter, Kashyap] - Use existing rST conventions to make `rst2html5` happy [Michal] - Update meson.build [Michal] - Use .contents:: [Michal] - Paragraph alignment [Michal]
Kashyap Chamarthy (2): docs: kbase: Add a doc on live full disk backup docs: kbase: Add a doc on merging disk image chains
docs/kbase/live_full_disk_backup.rst | 186 +++++++++++++++++++++ docs/kbase/merging_disk_image_chains.rst | 200 +++++++++++++++++++++++ docs/kbase/meson.build | 2 + 3 files changed, 388 insertions(+) create mode 100644 docs/kbase/live_full_disk_backup.rst create mode 100644 docs/kbase/merging_disk_image_chains.rst
Patches look good and I'm inclined to merge them. Thank you for reworking v1 per our reviews. However, what I completely missed in my review of v1 is to add links from docs/kbase/index.rst to new pages you're introducing. I can fix that before push if you reply with a diff that would do just that.
Duh, I was thinking "I missed something but not sure what". Thanks for the review and fixing it up. Here we go, the index.rst `diff`: $> git diff docs/kbase/index.rst diff --git a/docs/kbase/index.rst b/docs/kbase/index.rst index 532804fe05..d483ca94de 100644 --- a/docs/kbase/index.rst +++ b/docs/kbase/index.rst @@ -37,6 +37,12 @@ Usage `Launch security <launch_security_sev.html>`__ Securely launching VMs with AMD SEV +`Live full disk backup <live_full_disk_backup.html>`__ + A walkthrough of how to take effective live full disk backups. + +`Merging disk image chains <merging_disk_image_chains.html>`__ + Ways to reduce or consolidate disk image chains. + `KVM real time <kvm-realtime.html>`__ Run real time workloads in guests on a KVM hypervisor -- /kashyap

On 5/11/21 10:29 AM, Kashyap Chamarthy wrote:
On Tue, May 11, 2021 at 09:54:28AM +0200, Michal Prívozník wrote:
On 5/10/21 6:39 PM, Kashyap Chamarthy wrote:
I don't think the Debian "sid" failure is related to my patch:
https://gitlab.com/kashyapc/libvirt/-/pipelines/300380749/failures
Changes in v2:
- Mention backupBegin() [Peter] - Add examples of push-mode backup using backupBegin() [Peter, Kashyap] - Use existing rST conventions to make `rst2html5` happy [Michal] - Update meson.build [Michal] - Use .contents:: [Michal] - Paragraph alignment [Michal]
Kashyap Chamarthy (2): docs: kbase: Add a doc on live full disk backup docs: kbase: Add a doc on merging disk image chains
docs/kbase/live_full_disk_backup.rst | 186 +++++++++++++++++++++ docs/kbase/merging_disk_image_chains.rst | 200 +++++++++++++++++++++++ docs/kbase/meson.build | 2 + 3 files changed, 388 insertions(+) create mode 100644 docs/kbase/live_full_disk_backup.rst create mode 100644 docs/kbase/merging_disk_image_chains.rst
Patches look good and I'm inclined to merge them. Thank you for reworking v1 per our reviews. However, what I completely missed in my review of v1 is to add links from docs/kbase/index.rst to new pages you're introducing. I can fix that before push if you reply with a diff that would do just that.
Duh, I was thinking "I missed something but not sure what". Thanks for the review and fixing it up. Here we go, the index.rst `diff`:
$> git diff docs/kbase/index.rst diff --git a/docs/kbase/index.rst b/docs/kbase/index.rst index 532804fe05..d483ca94de 100644 --- a/docs/kbase/index.rst +++ b/docs/kbase/index.rst @@ -37,6 +37,12 @@ Usage `Launch security <launch_security_sev.html>`__ Securely launching VMs with AMD SEV
+`Live full disk backup <live_full_disk_backup.html>`__ + A walkthrough of how to take effective live full disk backups. + +`Merging disk image chains <merging_disk_image_chains.html>`__ + Ways to reduce or consolidate disk image chains. + `KVM real time <kvm-realtime.html>`__ Run real time workloads in guests on a KVM hypervisor
Thank you, I've merged these to their respective patches and pushed. Reviewed-by: Michal Privoznik <mprivozn@redhat.com> Michal
participants (2)
-
Kashyap Chamarthy
-
Michal Prívozník