[libvir] [PATCH] Change group ownership of /var/run/libvirt/
2008/4/24, Daniel Veillard <veillard@redhat.com>:
Okay, I take patches :-)
thanks !
Daniel
Here it is. The changes are: 1) If libvirtd is running as root, main() will try to change the group ownership of /var/run/libvirt to one specified by unix_sock_gid. 2) Default permissions on /var/run/libvirt are now 0750 A.
On Thu, Apr 24, 2008 at 07:20:45PM +0400, Anton Protopopov wrote:
1) If libvirtd is running as root, main() will try to change the group ownership of /var/run/libvirt to one specified by unix_sock_gid. 2) Default permissions on /var/run/libvirt are now 0750 How does this match with the default permissions of the read only socket? unix_sock_ro_perms = "0777" Shouldnt the /var/run/libvirt stay 0755? -- Guido
2008/4/25, Guido Günther <agx@sigxcpu.org>:
On Thu, Apr 24, 2008 at 07:20:45PM +0400, Anton Protopopov wrote:
1) If libvirtd is running as root, main() will try to change the group ownership of /var/run/libvirt to one specified by unix_sock_gid. 2) Default permissions on /var/run/libvirt are now 0750
How does this match with the default permissions of the read only socket? unix_sock_ro_perms = "0777"
Yes, you are right. That doesn't match...
Shouldnt the /var/run/libvirt stay 0755?
Yes, it should.
-- Guido
New patch is attached A.
On Fri, Apr 25, 2008 at 12:57:23PM +0400, Anton Protopopov wrote:
2008/4/25, Guido Günther <agx@sigxcpu.org>:
On Thu, Apr 24, 2008 at 07:20:45PM +0400, Anton Protopopov wrote:
1) If libvirtd is running as root, main() will try to change the group ownership of /var/run/libvirt to one specified by unix_sock_gid. 2) Default permissions on /var/run/libvirt are now 0750
How does this match with the default permissions of the read only socket? unix_sock_ro_perms = "0777"
Yes, you are right. That doesn't match...
Shouldnt the /var/run/libvirt stay 0755?
Yes, it should.
-- Guido
New patch is attached
Okidoc, patch applied ! thanks :-) Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
participants (3)
-
Anton Protopopov -
Daniel Veillard -
Guido Günther