[libvirt] [PATCH] qemu: Only check for NUMA availability if required
We only care about NUMA availability if NUMA configuration is requested in domain XML. --- src/qemu/qemu_process.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 8e09e52..37d5a22 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -1197,17 +1197,17 @@ qemuProcessInitNumaMemoryPolicy(virDomainObjPtr vm) int i = 0; int maxnode = 0; + if (!vm->def->numatune.memory.nodemask) + return 0; + VIR_DEBUG("Setting NUMA memory policy"); if (numa_available() < 0) { qemuReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Host kernel is not aware of NUMA.")); return -1; } - if (!vm->def->numatune.memory.nodemask) - return 0; - if (VIR_ALLOC(mask) < 0) { virReportOOMError(); return -1; -- 1.7.5.3
On 06/21/2011 10:55 AM, Jiri Denemark wrote:
We only care about NUMA availability if NUMA configuration is requested in domain XML. --- src/qemu/qemu_process.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
ACK. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
On Tue, Jun 21, 2011 at 11:13:47 -0600, Eric Blake wrote:
On 06/21/2011 10:55 AM, Jiri Denemark wrote:
We only care about NUMA availability if NUMA configuration is requested in domain XML. --- src/qemu/qemu_process.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
ACK.
Pushed now. Thanks. Jirka
于 2011年06月22日 00:55, Jiri Denemark 写道:
We only care about NUMA availability if NUMA configuration is requested in domain XML. --- src/qemu/qemu_process.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 8e09e52..37d5a22 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -1197,17 +1197,17 @@ qemuProcessInitNumaMemoryPolicy(virDomainObjPtr vm) int i = 0; int maxnode = 0;
+ if (!vm->def->numatune.memory.nodemask) + return 0; + VIR_DEBUG("Setting NUMA memory policy");
if (numa_available()< 0) { qemuReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Host kernel is not aware of NUMA.")); return -1; }
- if (!vm->def->numatune.memory.nodemask) - return 0; - if (VIR_ALLOC(mask)< 0) { virReportOOMError(); return -1;
Thanks for detecting this, ACK Regards Osier
participants (3)
-
Eric Blake -
Jiri Denemark -
Osier Yang