[Libvir] PATCH: Fix QEMU autostart/network behaviour

In my testing there appeared to be a couple of bugs with the QEMU driver and the interaction with networking - It was auto-starting the daemon even with qemu://system - It was opening the QEMU connection twice due to inverted check, and not opening it at all in the non-QEMU hv case. - Once that is fixed, then it SEGVs when using a Xen connection as uri->scheme is NULL That attached patch rectifies those flaws - Mark can you double check this just in case I've missed some edge case for the networking stuff - I have strace'd virsh when doing virsh list (as root & non-root) virsh --connect test://default list (as root & non-root) virsh --connect xen list (as root & non-root) virsh --connect qemu://session list (as non-root) virsh --connect qemu://system list (as root) virsh --connect qemu://session --readonly list (as non-root) virsh --connect qemu://system --readonly list (as root & non-root) And it appears to now be making the correct connectiosn to the QEMU daemons in all cases Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

On Thu, 2007-03-08 at 14:48 +0000, Daniel P. Berrange wrote:
In my testing there appeared to be a couple of bugs with the QEMU driver and the interaction with networking
- It was auto-starting the daemon even with qemu://system - It was opening the QEMU connection twice due to inverted check, and not opening it at all in the non-QEMU hv case. - Once that is fixed, then it SEGVs when using a Xen connection as uri->scheme is NULL
That attached patch rectifies those flaws - Mark can you double check this just in case I've missed some edge case for the networking stuff
Nice catches, it all looks good to me. Cheers, Mark.
participants (2)
-
Daniel P. Berrange
-
Mark McLoughlin