[libvirt] error in libvirt.py from libvirt-0.6.1 ?

Hello Is there a paticular reason for having "def migrate" two times in libvirt.py? The first occurence is on line 345 with parameters (self, dconn, flags, dname, uri, bandwidth) The second occurence is on line 1102 with parameters (self, domain, flags, dname, uri, bandwidth) Which one is correct? And i am no python programmer in the least, but isn't the ret set false? ret = libvirtmod.virDomainMigrate(domain__o, self._o, flags, dname, uri, bandwidth) That doesn't correspond to the def some above this earlier. diff /tmp/migrate_1st_occurance /tmp/migrate_2nd_occurance 1c1 < def migrate(self, dconn, flags, dname, uri, bandwidth): ---
def migrate(self, domain, flags, dname, uri, bandwidth):
31,34c31,34 < if dconn is None: dconn__o = None < else: dconn__o = dconn._o < ret = libvirtmod.virDomainMigrate(self._o, dconn__o, flags, dname, uri, bandwidth) < if ret is None:raise libvirtError('virDomainMigrate() failed', dom=self) ---
if domain is None: domain__o = None else: domain__o = domain._o ret = libvirtmod.virDomainMigrate(domain__o, self._o, flags,
dname, uri, bandwidth)
if ret is None:raise libvirtError('virDomainMigrate()
failed', conn=self)

On Tue, Mar 31, 2009 at 08:23:07PM +0200, Gerrit Slomma wrote:
Hello
Is there a paticular reason for having "def migrate" two times in libvirt.py? The first occurence is on line 345 with parameters (self, dconn, flags, dname, uri, bandwidth)
This is the correct one, in the virDomain: class.
The second occurence is on line 1102 with parameters (self, domain, flags, dname, uri, bandwidth)
This one in virConnect: class is bogus. Something must have confused the code generator here Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
participants (2)
-
Daniel P. Berrange
-
Gerrit Slomma