[libvirt] [PATCH 0/4] Doc update changes for my recent commits
These are all trivial and will push in a bit - I was essentially waiting for the news.html.in or news.xml to shake out before adjusting. John Ferlan (4): docs: Document the new vHBA/NPIV params for storage docs: Add NPIV/vHBA change description to news.xml docs: Add file system pool overwrite change description to news.xml docs: Add logical storage pool overwrite change description to news.xml docs/formatstorage.html.in | 17 +++++++++++++++++ docs/news.xml | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 51 insertions(+) -- 2.7.4
Commit id 'bb74a7ffe' forgot to adjust the storage docs to describe the new fields. Signed-off-by: John Ferlan <jferlan@redhat.com> --- docs/formatstorage.html.in | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in index a7273ed..f6887ae 100644 --- a/docs/formatstorage.html.in +++ b/docs/formatstorage.html.in @@ -237,6 +237,23 @@ the scsi_hostN of some existing storage pool. <span class="since">Since 1.0.4</span> </dd> + <dt><code>parent_wwnn</code> and <code>parent_wwpn</code></dt> + <dd>Instead of the <code>parent</code> to specify which scsi_host + to use by name, it's possible to provide the wwnn and wwpn of + the parent to be used for the vHBA in order to ensure that + between reboots or after a hardware configuration change that + the scsi_host parent name doesn't change. Both the parent_wwnn + and parent_wwpn must be provided. + <span class="since">Since 3.0.0</span> + </dd> + <dt><code>parent_fabric_wwn</code></dt> + <dd>Instead of the <code>parent</code> to specify which scsi_host + to use by name, it's possible to provide the fabric_wwn on which + the scsi_host exists. This provides flexibility for choosing + a scsi_host that may be available on the fabric rather than + requiring a specific parent by wwnn or wwpn to be available. + <span class="since">Since 3.0.0</span> + </dd> <dt><code>managed</code></dt> <dd>An optional attribute to instruct the SCSI storage backend to manage destroying the vHBA when the pool is destroyed. For -- 2.7.4
On Wed, Jan 11, 2017 at 07:25:52AM -0500, John Ferlan wrote:
Commit id 'bb74a7ffe' forgot to adjust the storage docs to describe the new fields.
Signed-off-by: John Ferlan <jferlan@redhat.com> --- docs/formatstorage.html.in | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in index a7273ed..f6887ae 100644 --- a/docs/formatstorage.html.in +++ b/docs/formatstorage.html.in @@ -237,6 +237,23 @@ the scsi_hostN of some existing storage pool. <span class="since">Since 1.0.4</span> </dd> + <dt><code>parent_wwnn</code> and <code>parent_wwpn</code></dt> + <dd>Instead of the <code>parent</code> to specify which scsi_host + to use by name, it's possible to provide the wwnn and wwpn of + the parent to be used for the vHBA in order to ensure that + between reboots or after a hardware configuration change that + the scsi_host parent name doesn't change. Both the parent_wwnn + and parent_wwpn must be provided. + <span class="since">Since 3.0.0</span> + </dd> + <dt><code>parent_fabric_wwn</code></dt> + <dd>Instead of the <code>parent</code> to specify which scsi_host + to use by name, it's possible to provide the fabric_wwn on which + the scsi_host exists. This provides flexibility for choosing + a scsi_host that may be available on the fabric rather than + requiring a specific parent by wwnn or wwpn to be available. + <span class="since">Since 3.0.0</span> + </dd> <dt><code>managed</code></dt> <dd>An optional attribute to instruct the SCSI storage backend to manage destroying the vHBA when the pool is destroyed. For -- 2.7.4
ACK, safe for freeze (since it's docs). Have you seen this [1] patch? I think I understand it righ, but since you implemented it, it'd be nice to have your input on that as well. [1] https://www.redhat.com/archives/libvir-list/2017-January/msg00519.html
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Add "Improvements" for commit id 'bb74a7ffe' and '78be2e8b7' which add support for using the parent wwnn/wwpn or fabric_name rather than just using the parent by scsi_hostX name. Signed-off-by: John Ferlan <jferlan@redhat.com> --- docs/news.xml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 300e553..13f6965 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -118,6 +118,18 @@ of units in bytes rather than default of human readable output. </description> </change> + <change> + <summary> + scsi: Add parent wwnn/wwpn or fabric capability for createVport + </summary> + <description> + Improve the algorithm searching for the parent scsi_host device + for vHBA/NPIV scsi_host creation. Rather than supplying the + "parent" by name, it's now possible to define the parent by + it's wwnn/wwpn or fabric_wwn in the node device create XML or + the storage pool XML. + </description> + </change> </section> <section title="Bug fixes"> <change> -- 2.7.4
Add bug fixes description of overwrite changes for a file system storage pool Signed-off-by: John Ferlan <jferlan@redhat.com> --- docs/news.xml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 13f6965..ec65766 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -162,6 +162,18 @@ <code>/dev</code>. </description> </change> + <change> + <summary> + storage: Fix implementation of no-overwrite for file system backend + </summary> + <description> + Fix file system storage backend implementation of the OVERWRITE + flags to be consistent between code and documentation. Add checks + to ensure that when building a new file system on a target volume + that there is not something already on the disk in a format that + libvirt can recognize. + </description> + </change> </section> </release> <release version="v2.5.0" date="2016-12-04"> -- 2.7.4
On Wed, Jan 11, 2017 at 07:25:54AM -0500, John Ferlan wrote:
Add bug fixes description of overwrite changes for a file system storage pool
Signed-off-by: John Ferlan <jferlan@redhat.com> --- docs/news.xml | 12 ++++++++++++ 1 file changed, 12 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml index 13f6965..ec65766 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -162,6 +162,18 @@ <code>/dev</code>. </description> </change> + <change> + <summary> + storage: Fix implementation of no-overwrite for file system backend + </summary> + <description> + Fix file system storage backend implementation of the OVERWRITE + flags to be consistent between code and documentation. Add checks + to ensure that when building a new file system on a target volume + that there is not something already on the disk in a format that + libvirt can recognize.
This is pretty long and confusing sentence, especially without any punctuation. ACK to this, but I'd be also fine with it being reworde slightly.
+ </description> + </change> </section> </release> <release version="v2.5.0" date="2016-12-04"> -- 2.7.4
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Add "New Features" entry to describe the overwrite flag for logical backend. Signed-off-by: John Ferlan <jferlan@redhat.com> --- docs/news.xml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index ec65766..e341ba2 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -63,6 +63,16 @@ libxl: Implement virDomainGetMaxVcpus API </summary> </change> + <change> + <summary> + storage: Add overwrite flag checking for logical pool + </summary> + <description> + Add support for the OVERWRITE flags for the logical storage + backend including checking for existing data on the target + volumes when building a new logical pool on target volume(s). + </description> + </change> </section> <section title="Improvements"> <change> -- 2.7.4
On Wed, Jan 11, 2017 at 07:25:51AM -0500, John Ferlan wrote:
These are all trivial and will push in a bit - I was essentially waiting for the news.html.in or news.xml to shake out before adjusting.
John Ferlan (4): docs: Document the new vHBA/NPIV params for storage docs: Add NPIV/vHBA change description to news.xml docs: Add file system pool overwrite change description to news.xml docs: Add logical storage pool overwrite change description to news.xml
The last two could be one entry, since it's similar thing. Also "Add ... description to news.xml" could be just "news:" prefix ;) ACK series (with tiny comments), safe for freeze
docs/formatstorage.html.in | 17 +++++++++++++++++ docs/news.xml | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 51 insertions(+)
-- 2.7.4
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
participants (2)
-
John Ferlan -
Martin Kletzander