>> +static int >> +libxlDomainAbortJob(virDomainPtr dom) >> +{ >> + libxlDriverPrivatePtr driver = dom->conn->privateData; >> + virDomainObjPtr vm; >> + int ret = -1; >> + libxlDomainObjPrivatePtr priv; >> + >> + libxlDriverLock(driver); >> + vm = virDomainFindByUUID(&driver->domains, dom->uuid); >> + libxlDriverUnlock(driver); >> + if (!vm) { >> + char uuidstr[VIR_UUID_STRING_BUFLEN]; >> + virUUIDFormat(dom->uuid, uuidstr); >> + virReportError(VIR_ERR_NO_DOMAIN, >> + _("no domain with matching uuid '%s'"), uuidstr); >> + goto cleanup; >> + } >> + >> + if (libxlDomainObjBeginJob(driver, vm, LIBXL_JOB_ABORT) < 0) >> + goto cleanup; >> + >> + if (!virDomainObjIsActive(vm)) { >> + virReportError(VIR_ERR_OPERATION_INVALID, >> + "%s", _("domain is not running")); >> + goto endjob; >> + } >> + >> + priv = vm->privateData; >> + >> + if (!priv->job.asyncJob) { >> + virReportError(VIR_ERR_OPERATION_INVALID, >> + "%s", _("no job is active on the domain")); >> + goto endjob; >> + } else { >> + virReportError(VIR_ERR_OPERATION_INVALID, >> + _("cannot abort %s; use virDomainDestroy instead"), >> + libxlDomainAsyncJobTypeToString(priv->job.asyncJob)); >> + goto endjob; >> + } >> >> > > This function will always fail with the above logic. ret is initialized > to -1 and is never changed. > > Is it even possible to safely abort a libxl operation? If not, this > function should probably remain unimplemented. Maybe it will be useful > when the libxl driver supports migration. > return error because of the there is no cancelation opeartion in libvirt libxl driver with xen 4.1. according to xen4.2 release document, maybe the cancelation of long-running jobs is supported.

but it is still useful for save, dump and migration(in future), because libvirt should block the user abort operation othervise xenlight might crash