[libvirt] [PATCH] qemu_process: spice: don't release used port
The port is stored in graphics configuration and it will also get released in qemuProcessStop in case of error. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1397440 Signed-off-by: Pavel Hrdina <phrdina@redhat.com> --- src/qemu/qemu_process.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index df1fa0371d..760507d957 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -3693,7 +3693,6 @@ qemuProcessSPICEAllocatePorts(virQEMUDriverPtr driver, ret = 0; cleanup: - virPortAllocatorRelease(driver->remotePorts, port); virObjectUnref(cfg); return ret; } -- 2.11.1
On Fri, Feb 24, 2017 at 09:58:31AM +0100, Pavel Hrdina wrote:
The port is stored in graphics configuration and it will also get released in qemuProcessStop in case of error.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1397440
Signed-off-by: Pavel Hrdina <phrdina@redhat.com> --- src/qemu/qemu_process.c | 1 - 1 file changed, 1 deletion(-)
Nice how one removed line fixes two different issues :) ACK
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index df1fa0371d..760507d957 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -3693,7 +3693,6 @@ qemuProcessSPICEAllocatePorts(virQEMUDriverPtr driver, ret = 0;
cleanup: - virPortAllocatorRelease(driver->remotePorts, port); virObjectUnref(cfg); return ret; } -- 2.11.1
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
participants (2)
-
Martin Kletzander -
Pavel Hrdina