[libvirt] [PATCH] travis: Uninstall packages before upgrade
numpy (needed by cgal) started having the same issue with linking as python, which makes upgrade and thus the entire build fail on macOS. Instead of playing more tricks with linking/unlinking, just uninstall the problematic packages (and those dragging them in) before doing anything else. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- Technically a build breaker, but since I'm changing the approach I'd rather wait for an explicit ACK before pushing. .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index d3f72d46f3..140072b801 100644 --- a/.travis.yml +++ b/.travis.yml @@ -21,10 +21,10 @@ matrix: - compiler: clang os: osx before_install: + - brew uninstall python mercurial postgis sfcgal cgal gdal - brew update - - brew unlink python - brew upgrade - - brew install rpcgen yajl + - brew install python rpcgen yajl script: # We can't run make distcheck/syntax-check because they # fail on macOS, but doing 'install' and 'dist' gives us -- 2.17.0
On Mon, May 14, 2018 at 12:07:45PM +0200, Andrea Bolognani wrote:
numpy (needed by cgal) started having the same issue with linking as python, which makes upgrade and thus the entire build fail on macOS.
Instead of playing more tricks with linking/unlinking, just uninstall the problematic packages (and those dragging them in) before doing anything else.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- Technically a build breaker, but since I'm changing the approach I'd rather wait for an explicit ACK before pushing.
.travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.travis.yml b/.travis.yml index d3f72d46f3..140072b801 100644 --- a/.travis.yml +++ b/.travis.yml @@ -21,10 +21,10 @@ matrix: - compiler: clang os: osx before_install: + - brew uninstall python mercurial postgis sfcgal cgal gdal - brew update - - brew unlink python - brew upgrade - - brew install rpcgen yajl + - brew install python rpcgen yajl script: # We can't run make distcheck/syntax-check because they # fail on macOS, but doing 'install' and 'dist' gives us
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On 05/14/2018 12:07 PM, Andrea Bolognani wrote:
numpy (needed by cgal) started having the same issue with linking as python, which makes upgrade and thus the entire build fail on macOS.
Instead of playing more tricks with linking/unlinking, just uninstall the problematic packages (and those dragging them in) before doing anything else.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- Technically a build breaker, but since I'm changing the approach I'd rather wait for an explicit ACK before pushing.
.travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.travis.yml b/.travis.yml index d3f72d46f3..140072b801 100644 --- a/.travis.yml +++ b/.travis.yml @@ -21,10 +21,10 @@ matrix: - compiler: clang os: osx before_install: + - brew uninstall python mercurial postgis sfcgal cgal gdal - brew update - - brew unlink python - brew upgrade - - brew install rpcgen yajl + - brew install python rpcgen yajl script: # We can't run make distcheck/syntax-check because they # fail on macOS, but doing 'install' and 'dist' gives us
This OSX support is becoming more and more hairy. It's fairly often broken and we do nothing but compile test it (we don't even run make check there). So we can't be really sure the compiled virsh/client library still works there. I think it's time to have a discussion about dropping OSX support. Do we know if we even have any consumers running libvirt on OSX? Michal
On Mon, 2018-05-14 at 16:12 +0200, Michal Privoznik wrote:
This OSX support is becoming more and more hairy. It's fairly often broken and we do nothing but compile test it (we don't even run make check there). So we can't be really sure the compiled virsh/client library still works there. I think it's time to have a discussion about dropping OSX support. Do we know if we even have any consumers running libvirt on OSX?
According to https://brew.sh/analytics/install/ there's some 20K people with libvirt installed on their macOS machine; I think it's fair to assume at least a fraction of them are actually using it. Compiling on non-Linux platforms allows us to keep libvirt farily portable, so having FreeBSD, MinGW and macOS builds running as part of our CI setup is IMHO extremely valuable. I consider macOS very much a "best effort" kind of deal, since it's basically impossible to solve all but the most trivial issues hitting it without first gaining access to proprietary platforms, which is something that I'm personally not interested in doing. That said, as long as we can keep it building by tweaking a couple of lines every few months, I don't see a compelling argument for dropping macOS support. -- Andrea Bolognani / Red Hat / Virtualization
participants (3)
-
Andrea Bolognani -
Daniel P. Berrangé -
Michal Privoznik