So, when I merged my changes up yesterday to some of the developments going on, it would seem that one of the changesets I pulled in had a bit of a reduction in configure flexibility. I'm not yet sure what changeset caused it...but I used to be able to specify an external xen tree with the following line in a Makefile... ./autogen.sh --prefix=/usr --with-xen=$(XEN_SRC)/dist/install/usr This now seems to fail to find that xen tree, as I error out with: gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../gnulib/lib -I../gnulib/lib -I../include -I../include -I../qemud -I/usr/include/libxml2 -DBINDIR=\"/usr/libexec\" -DSBINDIR=\"/usr/sbin\" -DSYSCONF_DIR=\"/etc\" -DLOCALEBASEDIR=\"/usr/share/locale\" -DLOCAL_STATE_DIR=\"/var\" -DGETTEXT_PACKAGE=\"libvirt\" -Wall -Wformat -Wformat-security -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wextra -Wshadow -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Winline -Wredundant-decls -Wno-sign-compare -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fasynchronous-unwind-tables -g -O2 -MT stats_linux.lo -MD -MP -MF .deps/stats_linux.Tpo -c stats_linux.c -fPIC -DPIC -o .libs/stats_linux.o stats_linux.c:24:16: error: xs.h: No such file or directory stats_linux.c: In function 'check_bd_connected': stats_linux.c:154: warning: implicit declaration of function 'xs_read' stats_linux.c:154: warning: nested extern declaration of 'xs_read' stats_linux.c:154: warning: assignment makes pointer from integer without a cast I assume this has something to do with Daniel B's changes to configure scripts recently. Could you give me a pointer as to where I should be looking? Ben -- Libvir-list mailing list Libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

On Thu, Nov 20, 2008 at 01:27:40PM -0500, Ben Guthro wrote: > I tried this...didn't seem to help: Sorry, not paying close enough attention. In fact this file was built in an earlier module. Find the line which says libvirt_driver_la_SOURCES = \ $(DRIVER_SOURCES) \ $(DOMAIN_CONF_SOURCES) \ $(NETWORK_CONF_SOURCES) \ $(STORAGE_CONF_SOURCES) \ $(NODE_DEVICE_CONF_SOURCES) And add in a line following that libvirt_driver_la_CFLAGS = $(XEN_CFLAGS)

Oh - sorry for not getting back to you about this. Yes - it does solve it for me. +1 -----Original Message----- From: Daniel P. Berrange [mailto:berrange@redhat.com] Sent: Fri 11/21/2008 5:12 AM To: Ben Guthro Cc: libvir-list Subject: Re: [libvirt] --with-xen=foo On Thu, Nov 20, 2008 at 06:30:38PM +0000, Daniel P. Berrange wrote: > On Thu, Nov 20, 2008 at 01:27:40PM -0500, Ben Guthro wrote: > > I tried this...didn't seem to help: > > Sorry, not paying close enough attention. In fact this file was > built in an earlier module. Find the line which says > > libvirt_driver_la_SOURCES = \ > $(DRIVER_SOURCES) \ > $(DOMAIN_CONF_SOURCES) \ > $(NETWORK_CONF_SOURCES) \ > $(STORAGE_CONF_SOURCES) \ > $(NODE_DEVICE_CONF_SOURCES) > > And add in a line following that > > libvirt_driver_la_CFLAGS = $(XEN_CFLAGS) On the assumption that this fixed it for you, I've committed this change Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| ------------------------------------------------------------------------ -- Libvir-list mailing list Libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list