[libvirt] [jenkins-ci PATCH] hosts_vars: drop virt-viewer from platforms with old spice-gtk
git master requires spice-gtk >= 0.35 Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- guests/host_vars/libvirt-centos-7/main.yml | 1 - guests/host_vars/libvirt-debian-8/main.yml | 1 - guests/host_vars/libvirt-debian-9/main.yml | 1 - guests/host_vars/libvirt-debian-sid/main.yml | 1 - guests/host_vars/libvirt-fedora-27/main.yml | 1 - guests/host_vars/libvirt-freebsd-10/main.yml | 1 - guests/host_vars/libvirt-freebsd-11/main.yml | 1 - guests/host_vars/libvirt-freebsd-current/main.yml | 1 - guests/host_vars/libvirt-ubuntu-14/main.yml | 1 - guests/host_vars/libvirt-ubuntu-16/main.yml | 1 - guests/host_vars/libvirt-ubuntu-18/main.yml | 1 - 11 files changed, 11 deletions(-) diff --git a/guests/host_vars/libvirt-centos-7/main.yml b/guests/host_vars/libvirt-centos-7/main.yml index c147830..19e905e 100644 --- a/guests/host_vars/libvirt-centos-7/main.yml +++ b/guests/host_vars/libvirt-centos-7/main.yml @@ -12,4 +12,3 @@ projects: - libvirt-sandbox - osinfo-db - osinfo-db-tools - - virt-viewer diff --git a/guests/host_vars/libvirt-debian-8/main.yml b/guests/host_vars/libvirt-debian-8/main.yml index 954a037..62abfd3 100644 --- a/guests/host_vars/libvirt-debian-8/main.yml +++ b/guests/host_vars/libvirt-debian-8/main.yml @@ -10,4 +10,3 @@ projects: - libvirt-tck - osinfo-db - osinfo-db-tools - - virt-viewer diff --git a/guests/host_vars/libvirt-debian-9/main.yml b/guests/host_vars/libvirt-debian-9/main.yml index a588c09..032572f 100644 --- a/guests/host_vars/libvirt-debian-9/main.yml +++ b/guests/host_vars/libvirt-debian-9/main.yml @@ -13,4 +13,3 @@ projects: - osinfo-db - osinfo-db-tools - virt-manager - - virt-viewer diff --git a/guests/host_vars/libvirt-debian-sid/main.yml b/guests/host_vars/libvirt-debian-sid/main.yml index a588c09..032572f 100644 --- a/guests/host_vars/libvirt-debian-sid/main.yml +++ b/guests/host_vars/libvirt-debian-sid/main.yml @@ -13,4 +13,3 @@ projects: - osinfo-db - osinfo-db-tools - virt-manager - - virt-viewer diff --git a/guests/host_vars/libvirt-fedora-27/main.yml b/guests/host_vars/libvirt-fedora-27/main.yml index 00b0848..bc13420 100644 --- a/guests/host_vars/libvirt-fedora-27/main.yml +++ b/guests/host_vars/libvirt-fedora-27/main.yml @@ -14,4 +14,3 @@ projects: - osinfo-db - osinfo-db-tools - virt-manager - - virt-viewer diff --git a/guests/host_vars/libvirt-freebsd-10/main.yml b/guests/host_vars/libvirt-freebsd-10/main.yml index 2ad4584..903dd45 100644 --- a/guests/host_vars/libvirt-freebsd-10/main.yml +++ b/guests/host_vars/libvirt-freebsd-10/main.yml @@ -14,4 +14,3 @@ projects: - osinfo-db - osinfo-db-tools - virt-manager - - virt-viewer diff --git a/guests/host_vars/libvirt-freebsd-11/main.yml b/guests/host_vars/libvirt-freebsd-11/main.yml index 2ad4584..903dd45 100644 --- a/guests/host_vars/libvirt-freebsd-11/main.yml +++ b/guests/host_vars/libvirt-freebsd-11/main.yml @@ -14,4 +14,3 @@ projects: - osinfo-db - osinfo-db-tools - virt-manager - - virt-viewer diff --git a/guests/host_vars/libvirt-freebsd-current/main.yml b/guests/host_vars/libvirt-freebsd-current/main.yml index 2ad4584..903dd45 100644 --- a/guests/host_vars/libvirt-freebsd-current/main.yml +++ b/guests/host_vars/libvirt-freebsd-current/main.yml @@ -14,4 +14,3 @@ projects: - osinfo-db - osinfo-db-tools - virt-manager - - virt-viewer diff --git a/guests/host_vars/libvirt-ubuntu-14/main.yml b/guests/host_vars/libvirt-ubuntu-14/main.yml index 839c668..8b59152 100644 --- a/guests/host_vars/libvirt-ubuntu-14/main.yml +++ b/guests/host_vars/libvirt-ubuntu-14/main.yml @@ -7,4 +7,3 @@ projects: - libvirt-tck - osinfo-db - osinfo-db-tools - - virt-viewer diff --git a/guests/host_vars/libvirt-ubuntu-16/main.yml b/guests/host_vars/libvirt-ubuntu-16/main.yml index a588c09..032572f 100644 --- a/guests/host_vars/libvirt-ubuntu-16/main.yml +++ b/guests/host_vars/libvirt-ubuntu-16/main.yml @@ -13,4 +13,3 @@ projects: - osinfo-db - osinfo-db-tools - virt-manager - - virt-viewer diff --git a/guests/host_vars/libvirt-ubuntu-18/main.yml b/guests/host_vars/libvirt-ubuntu-18/main.yml index a588c09..032572f 100644 --- a/guests/host_vars/libvirt-ubuntu-18/main.yml +++ b/guests/host_vars/libvirt-ubuntu-18/main.yml @@ -13,4 +13,3 @@ projects: - osinfo-db - osinfo-db-tools - virt-manager - - virt-viewer -- 2.17.1
On Mon, 2018-07-30 at 10:04 +0100, Daniel P. Berrangé wrote:
git master requires spice-gtk >= 0.35
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- guests/host_vars/libvirt-centos-7/main.yml | 1 - guests/host_vars/libvirt-debian-8/main.yml | 1 - guests/host_vars/libvirt-debian-9/main.yml | 1 - guests/host_vars/libvirt-debian-sid/main.yml | 1 - guests/host_vars/libvirt-fedora-27/main.yml | 1 - guests/host_vars/libvirt-freebsd-10/main.yml | 1 - guests/host_vars/libvirt-freebsd-11/main.yml | 1 - guests/host_vars/libvirt-freebsd-current/main.yml | 1 - guests/host_vars/libvirt-ubuntu-14/main.yml | 1 - guests/host_vars/libvirt-ubuntu-16/main.yml | 1 - guests/host_vars/libvirt-ubuntu-18/main.yml | 1 - 11 files changed, 11 deletions(-)
All FreeBSD versions have 0.35, so they shouldn't be dropped; Debian Sid is still on 0.34, but I expect it will get 0.35 at some point in the not-too-distant future so I wouldn't touch that either, since it doesn't affect CentOS CI either way. More importantly: do we really want to stop building virt-viewer entirely on those platform just because a recent enough spice-gtk version is not available? Building without spice support still provides some amount of coverage (eg. VNC support), and the builds themselves don't fail, so I don't really see the upside of merging this. My suggestion would be to just disable the virt-viewer-master-rpm job on Fedora 27 and CentOS 7 and call it a day. -- Andrea Bolognani / Red Hat / Virtualization
On Mon, Jul 30, 2018 at 12:17:56PM +0200, Andrea Bolognani wrote:
On Mon, 2018-07-30 at 10:04 +0100, Daniel P. Berrangé wrote:
git master requires spice-gtk >= 0.35
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- guests/host_vars/libvirt-centos-7/main.yml | 1 - guests/host_vars/libvirt-debian-8/main.yml | 1 - guests/host_vars/libvirt-debian-9/main.yml | 1 - guests/host_vars/libvirt-debian-sid/main.yml | 1 - guests/host_vars/libvirt-fedora-27/main.yml | 1 - guests/host_vars/libvirt-freebsd-10/main.yml | 1 - guests/host_vars/libvirt-freebsd-11/main.yml | 1 - guests/host_vars/libvirt-freebsd-current/main.yml | 1 - guests/host_vars/libvirt-ubuntu-14/main.yml | 1 - guests/host_vars/libvirt-ubuntu-16/main.yml | 1 - guests/host_vars/libvirt-ubuntu-18/main.yml | 1 - 11 files changed, 11 deletions(-)
All FreeBSD versions have 0.35, so they shouldn't be dropped; Debian Sid is still on 0.34, but I expect it will get 0.35 at some point in the not-too-distant future so I wouldn't touch that either, since it doesn't affect CentOS CI either way.
More importantly: do we really want to stop building virt-viewer entirely on those platform just because a recent enough spice-gtk version is not available? Building without spice support still provides some amount of coverage (eg. VNC support), and the builds themselves don't fail, so I don't really see the upside of merging this.
My suggestion would be to just disable the virt-viewer-master-rpm job on Fedora 27 and CentOS 7 and call it a day.
Sigh, yes, I'm not thinking properly yet this morning Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
participants (2)
-
Andrea Bolognani -
Daniel P. Berrangé