Re: [Libvir] [patch 0/9] Add support for Fedora lokkit's --custom-rules option

Hey, Sounds like this series is good to commit, but just to be clear: 1) Need Dan's virRun() and virReadFile() patches in first 2) Patch 5/9 wasn't ACK-ed 3) Also need ACKs for the "use virRun()" and "add --enable-iptables-lokkit=check" patches Cheers, Mark.

On Mon, Jan 07, 2008 at 10:08:46AM +0000, Mark McLoughlin wrote:
Hey, Sounds like this series is good to commit, but just to be clear:
1) Need Dan's virRun() and virReadFile() patches in first
I've added the virReadFile patch now. If rich/DV like the virRun() patch I'll comitted that too...
2) Patch 5/9 wasn't ACK-ed
Opps, forgot to reply to that one - done now
3) Also need ACKs for the "use virRun()" and "add --enable-iptables-lokkit=check" patches
Done. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

On Mon, Jan 07, 2008 at 03:26:20PM +0000, Daniel P. Berrange wrote:
On Mon, Jan 07, 2008 at 10:08:46AM +0000, Mark McLoughlin wrote:
Hey, Sounds like this series is good to commit, but just to be clear:
1) Need Dan's virRun() and virReadFile() patches in first
I've added the virReadFile patch now. If rich/DV like the virRun() patch I'll comitted that too...
Hum, I may have missed that, what was the mail title ? Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

On Mon, Jan 07, 2008 at 10:36:54AM -0500, Daniel Veillard wrote:
On Mon, Jan 07, 2008 at 03:26:20PM +0000, Daniel P. Berrange wrote:
On Mon, Jan 07, 2008 at 10:08:46AM +0000, Mark McLoughlin wrote:
Hey, Sounds like this series is good to commit, but just to be clear:
1) Need Dan's virRun() and virReadFile() patches in first
I've added the virReadFile patch now. If rich/DV like the virRun() patch I'll comitted that too...
Hum, I may have missed that, what was the mail title ?
It was in reply to Mark's '6/9 Move iptablesSpawn' message http://www.redhat.com/archives/libvir-list/2008-January/msg00035.html Regards, Dan -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

On Mon, 2008-01-07 at 15:39 +0000, Daniel P. Berrange wrote:
On Mon, Jan 07, 2008 at 10:36:54AM -0500, Daniel Veillard wrote:
On Mon, Jan 07, 2008 at 03:26:20PM +0000, Daniel P. Berrange wrote:
On Mon, Jan 07, 2008 at 10:08:46AM +0000, Mark McLoughlin wrote:
Hey, Sounds like this series is good to commit, but just to be clear:
1) Need Dan's virRun() and virReadFile() patches in first
I've added the virReadFile patch now. If rich/DV like the virRun() patch I'll comitted that too...
Hum, I may have missed that, what was the mail title ?
It was in reply to Mark's '6/9 Move iptablesSpawn' message
http://www.redhat.com/archives/libvir-list/2008-January/msg00035.html
Still waiting for this to be ACK-ed and committed. Cheers, Mark.

On Thu, Jan 10, 2008 at 07:55:14AM +0000, Mark McLoughlin wrote:
On Mon, 2008-01-07 at 15:39 +0000, Daniel P. Berrange wrote:
On Mon, Jan 07, 2008 at 10:36:54AM -0500, Daniel Veillard wrote:
On Mon, Jan 07, 2008 at 03:26:20PM +0000, Daniel P. Berrange wrote:
On Mon, Jan 07, 2008 at 10:08:46AM +0000, Mark McLoughlin wrote:
Hey, Sounds like this series is good to commit, but just to be clear:
1) Need Dan's virRun() and virReadFile() patches in first
I've added the virReadFile patch now. If rich/DV like the virRun() patch I'll comitted that too...
Hum, I may have missed that, what was the mail title ?
It was in reply to Mark's '6/9 Move iptablesSpawn' message
http://www.redhat.com/archives/libvir-list/2008-January/msg00035.html
Still waiting for this to be ACK-ed and committed.
Feel free to commit my virRun patch along with all your others. Or I'll do it when I get into work later today if you've not already. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

On Thu, 2008-01-10 at 13:01 +0000, Daniel P. Berrange wrote:
On Thu, Jan 10, 2008 at 07:55:14AM +0000, Mark McLoughlin wrote:
On Mon, 2008-01-07 at 15:39 +0000, Daniel P. Berrange wrote:
It was in reply to Mark's '6/9 Move iptablesSpawn' message
http://www.redhat.com/archives/libvir-list/2008-January/msg00035.html
Still waiting for this to be ACK-ed and committed.
Feel free to commit my virRun patch along with all your others. Or I'll do it when I get into work later today if you've not already.
All pushed now. Thanks, Mark.
participants (3)
-
Daniel P. Berrange
-
Daniel Veillard
-
Mark McLoughlin