[libvirt] [PATCH] Assign virtio-serial addresses after coldplugging a device

Otherwise we might allow coldplugging a device that uses an address that is already occupied, creating an unstartable domain. https://bugzilla.redhat.com/show_bug.cgi?id=1076708#c10 --- src/qemu/qemu_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d173aa1..bab20c6 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -8326,6 +8326,8 @@ qemuDomainAttachDeviceConfig(virQEMUCapsPtr qemuCaps, dev->data.chr = NULL; if (virDomainDefAddImplicitControllers(vmdef) < 0) return -1; + if (qemuDomainAssignAddresses(vmdef, qemuCaps, NULL) < 0) + return -1; break; case VIR_DOMAIN_DEVICE_FS: -- 2.0.5

On 05/07/2015 07:46 AM, Ján Tomko wrote:
Otherwise we might allow coldplugging a device that uses an address that is already occupied, creating an unstartable domain.
https://bugzilla.redhat.com/show_bug.cgi?id=1076708#c10 --- src/qemu/qemu_driver.c | 2 ++ 1 file changed, 2 insertions(+)
ACK, John
participants (2)
-
John Ferlan
-
Ján Tomko