[PATCH 0/1] Fix the bug on disk->queue_size capability validation
Sorry, the patch I send in September 2021 had a mistake on capability check. This patch fixes that. Hiroki Narukawa (1): qemu_validate: Fix capability check for disk queue_size src/qemu/qemu_validate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1
Commit ad209e7d adds QEMU_CAPS_VIRTIO_BLK_QUEUE_SIZE capability, but the following commit 2d6d67e1 missed to use it and uses QEMU_CAPS_VIRTIO_BLK_NUM_QUEUES instead. This commit fixes the mistake. Signed-off-by: Hiroki Narukawa <hnarukaw@yahoo-corp.jp> --- src/qemu/qemu_validate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 4a82b512d1..e87a5fc65e 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -2861,7 +2861,7 @@ qemuValidateDomainDeviceDefDiskFrontend(const virDomainDiskDef *disk, return -1; } if (disk->queue_size > 0 && - !virQEMUCapsGet(qemuCaps, QEMU_CAPS_VIRTIO_BLK_NUM_QUEUES)) { + !virQEMUCapsGet(qemuCaps, QEMU_CAPS_VIRTIO_BLK_QUEUE_SIZE)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("queue-size property isn't supported by this QEMU binary")); return -1; -- 2.17.1
On 10/15/21 12:11 PM, Hiroki Narukawa wrote:
Commit ad209e7d adds QEMU_CAPS_VIRTIO_BLK_QUEUE_SIZE capability, but the following commit 2d6d67e1 missed to use it and uses QEMU_CAPS_VIRTIO_BLK_NUM_QUEUES instead.
This commit fixes the mistake.
Signed-off-by: Hiroki Narukawa <hnarukaw@yahoo-corp.jp> --- src/qemu/qemu_validate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Oops :-) Reviewed-by: Michal Privoznik <mprivozn@redhat.com> Michal
participants (2)
-
Hiroki Narukawa -
Michal Prívozník