[libvirt] [PATCH] esx: Add the actual product version to the error message.
This is just an old patch I had from when I was trying to use the 'esx://' URI scheme to access a vCenter resource (which turns out to use 'vpx://' instead, which was the problem I was having). It's useful for debugging purposes to print the actual product version from the server in the error message. Rich.
Really this should be a warning, not an error, but at least let's print out the product version so we have a hope of diagnosing the problem. error: internal error: v2v-vcenter is neither an ESX 3.5, 4.x nor 5.x host (product version = 0x40007) In this instance the error was that you have to use 'vpx://' instead of 'esx://'. --- src/esx/esx_driver.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index f0a5278..7d9e1c2 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -703,8 +703,8 @@ esxConnectToHost(esxPrivate *priv, priv->host->productVersion != esxVI_ProductVersion_ESX51 && priv->host->productVersion != esxVI_ProductVersion_ESX5x) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("%s is neither an ESX 3.5, 4.x nor 5.x host"), - conn->uri->server); + _("%s is neither an ESX 3.5, 4.x nor 5.x host (product version = 0x%x)"), + conn->uri->server, priv->host->productVersion); goto cleanup; } } else { /* GSX */ @@ -822,8 +822,8 @@ esxConnectToVCenter(esxPrivate *priv, priv->vCenter->productVersion != esxVI_ProductVersion_VPX51 && priv->vCenter->productVersion != esxVI_ProductVersion_VPX5x) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("%s is neither a vCenter 2.5, 4.x nor 5.x server"), - hostname); + _("%s is neither a vCenter 2.5, 4.x nor 5.x server (product version = 0x%x)"), + hostname, priv->host->productVersion); goto cleanup; } -- 2.0.4
On 09/08/14 15:35, Richard W.M. Jones wrote:
Really this should be a warning, not an error, but at least let's print out the product version so we have a hope of diagnosing the problem.
error: internal error: v2v-vcenter is neither an ESX 3.5, 4.x nor 5.x host (product version = 0x40007)
In this instance the error was that you have to use 'vpx://' instead of 'esx://'. --- src/esx/esx_driver.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index f0a5278..7d9e1c2 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -703,8 +703,8 @@ esxConnectToHost(esxPrivate *priv, priv->host->productVersion != esxVI_ProductVersion_ESX51 && priv->host->productVersion != esxVI_ProductVersion_ESX5x) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("%s is neither an ESX 3.5, 4.x nor 5.x host"), - conn->uri->server); + _("%s is neither an ESX 3.5, 4.x nor 5.x host (product version = 0x%x)"),
Long line, please wrap the part you've added to a new line (in the code, not in the actual message).
+ conn->uri->server, priv->host->productVersion); goto cleanup; } } else { /* GSX */ @@ -822,8 +822,8 @@ esxConnectToVCenter(esxPrivate *priv, priv->vCenter->productVersion != esxVI_ProductVersion_VPX51 && priv->vCenter->productVersion != esxVI_ProductVersion_VPX5x) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("%s is neither a vCenter 2.5, 4.x nor 5.x server"), - hostname); + _("%s is neither a vCenter 2.5, 4.x nor 5.x server (product version = 0x%x)"),
Same here.
+ hostname, priv->host->productVersion); goto cleanup; }
ACK with the modification. Peter
participants (2)
-
Peter Krempa -
Richard W.M. Jones