[libvirt PATCH for-8.0.0] virt-ssh-helper: Move manual page to section 8

While sections are somewhat loosely defined and thus the choice is not quite a clear-cut one, section 8 might be a slightly better fit in this case. Suggested-by: Olaf Hering <olaf@aepfle.de> Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- We could also merge this after 8.0.0, but I think it would be a little bit nicer if the manual page didn't move around between releases. docs/manpages/meson.build | 2 +- docs/manpages/virt-ssh-helper.rst | 2 +- libvirt.spec.in | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/manpages/meson.build b/docs/manpages/meson.build index 6763d19af8..150f45d296 100644 --- a/docs/manpages/meson.build +++ b/docs/manpages/meson.build @@ -19,11 +19,11 @@ docs_man_files = [ { 'name': 'virt-pki-query-dn', 'section': '1', 'install': true }, { 'name': 'virt-pki-validate', 'section': '1', 'install': true }, { 'name': 'virt-qemu-run', 'section': '1', 'install': conf.has('WITH_QEMU') }, - { 'name': 'virt-ssh-helper', 'section': '1', 'install': conf.has('WITH_LIBVIRTD') }, { 'name': 'virt-xml-validate', 'section': '1', 'install': true }, { 'name': 'libvirtd', 'section': '8', 'install': conf.has('WITH_LIBVIRTD') }, { 'name': 'virt-sanlock-cleanup', 'section': '8', 'install': conf.has('WITH_SANLOCK') }, + { 'name': 'virt-ssh-helper', 'section': '8', 'install': conf.has('WITH_LIBVIRTD') }, { 'name': 'virtbhyved', 'section': '8', 'install': conf.has('WITH_BHYVE') }, { 'name': 'virtinterfaced', 'section': '8', 'install': conf.has('WITH_INTERFACE') }, { 'name': 'virtlockd', 'section': '8', 'install': conf.has('WITH_LIBVIRTD') }, diff --git a/docs/manpages/virt-ssh-helper.rst b/docs/manpages/virt-ssh-helper.rst index 175ddacaec..9d0cf10bc3 100644 --- a/docs/manpages/virt-ssh-helper.rst +++ b/docs/manpages/virt-ssh-helper.rst @@ -6,7 +6,7 @@ virt-ssh-helper libvirt socket proxy -------------------- -:Manual section: 1 +:Manual section: 8 :Manual group: Virtualization Support .. contents:: diff --git a/libvirt.spec.in b/libvirt.spec.in index 7a90a1a9e6..db9d622699 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1693,7 +1693,7 @@ exit 0 %{_mandir}/man1/virt-admin.1* %{_mandir}/man1/virt-host-validate.1* -%{_mandir}/man1/virt-ssh-helper.1* +%{_mandir}/man8/virt-ssh-helper.8* %{_mandir}/man8/libvirtd.8* %{_mandir}/man8/virtlogd.8* %{_mandir}/man8/virtlockd.8* -- 2.31.1

On a Thursday in 2022, Andrea Bolognani wrote:
While sections are somewhat loosely defined and thus the choice is not quite a clear-cut one, section 8 might be a slightly better fit in this case.
Suggested-by: Olaf Hering <olaf@aepfle.de> Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- We could also merge this after 8.0.0, but I think it would be a little bit nicer if the manual page didn't move around between releases.
docs/manpages/meson.build | 2 +- docs/manpages/virt-ssh-helper.rst | 2 +- libvirt.spec.in | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
Assuming that CI passed for you: Reviewed-by: Ján Tomko <jtomko@redhat.com> Note that I'm absolutely open to addressing the situation by simply axing the file, and I don't think anything of value would be lost if we did that :) Jano [0] https://listman.redhat.com/archives/libvir-list/2022-January/msg00327.html

On Thu, Jan 13, 2022 at 03:34:55PM +0100, Ján Tomko wrote:
On a Thursday in 2022, Andrea Bolognani wrote:
docs/manpages/meson.build | 2 +- docs/manpages/virt-ssh-helper.rst | 2 +- libvirt.spec.in | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
Assuming that CI passed for you:
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Note that I'm absolutely open to addressing the situation by simply axing the file, and I don't think anything of value would be lost if we did that :)
Everyone loves a callback ;) Thanks for the review! I've pushed the patch now :) -- Andrea Bolognani / Red Hat / Virtualization
participants (2)
-
Andrea Bolognani
-
Ján Tomko