more descriptive as: qemu: fix vcpu pinning when not all vcpus are enabled

On Tue, Feb 26, 2019 at 10:01:28AM +0800, Yi Wang wrote: >vcpupin will fail when maxvcpus is larger than current >vcpu: > >virsh vcpupin win7 --vcpu 0 --cpulist 5-6 >error: Requested operation is not valid: cpu affinity is not supported > >win7 xml in the command above is like below: >... ><vcpu current="3" placement="static">8</vcpu> >... > >The reason is vcpu[3] and vcpu[4] have zero tids and should not been >compared as valid situation in qemuDomainRefreshVcpuInfo(). > >This issue is introduced by commit 34f7743, which fix recording of vCPU >pids for MTTCG. > >Signed-off-by: Yi Wang <wang.yi59(a)zte.com.cn&gt; >--- >v2: stop considering zero TIDs as duplicate. Thanks to Jano. >--- > src/qemu/qemu_domain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c >index ac01e86..c70d3f3 100644 >--- a/src/qemu/qemu_domain.c >+++ b/src/qemu/qemu_domain.c >@@ -10708,7 +10708,7 @@ qemuDomainRefreshVcpuInfo(virQEMUDriverPtr driver, > } > > for (j = 0; j < i; j++) { >- if (info[i].tid == info[j].tid) { >+ if (0 != info[i].tid && info[i].tid == info[j].tid) { The prevalent style is with the '0' on the right side. I'll fix that when pushing.

> VIR_DEBUG("vCPU[%zu] PID %llu duplicates vCPU[%zu]", > i, (unsigned long long)info[i].tid, j); > validTIDs = false; Reviewed-by: Ján Tomko <jtomko(a)redhat.com&gt; Jano