[PATCH 0/4] docs: formatdomain: misc fixes
A collection of formatdomain fixes that I've noticed over the past few months Cole Robinson (4): docs: formatdomain: remove doubled filesystem <driver> docs: formatdomain: fix incorrect 'Vsock' heading indent docs: formatdomain: fix net downscript 'since' docs: formatdomain: add spicevmc <redirdev> example docs/formatdomain.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.28.0
libvirt doesn't reject this but only one <driver> element takes effect. Drop the instance that is already referenced in the previous example Signed-off-by: Cole Robinson <crobinso@redhat.com> --- docs/formatdomain.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index f3cf9e1fb3..d75a91bbf4 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -3064,7 +3064,6 @@ A directory on the host that can be accessed directly from the guest. </filesystem> <filesystem type='file' accessmode='passthrough'> <driver type='loop' format='raw'/> - <driver type='path' wrpolicy='immediate'/> <source file='/export/to/guest.img'/> <target dir='/import/from/host'/> <readonly/> -- 2.28.0
On a Sunday in 2020, Cole Robinson wrote:
libvirt doesn't reject this but only one <driver> element takes effect.
Drop the instance that is already referenced in the previous example
Signed-off-by: Cole Robinson <crobinso@redhat.com> --- docs/formatdomain.rst | 1 - 1 file changed, 1 deletion(-)
Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano
Currently it is visually at the same indent as <seclabel>. This fixes it to be grouped it with <devices> Signed-off-by: Cole Robinson <crobinso@redhat.com> --- docs/formatdomain.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index d75a91bbf4..37c65add4d 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -7286,7 +7286,7 @@ Example: :anchor:`<a id="vsock"/>` Vsock ------ +~~~~~ A vsock host/guest interface. The ``model`` attribute defaults to ``virtio``. :since:`Since 5.2.0` ``model`` can also be 'virtio-transitional' and -- 2.28.0
On a Sunday in 2020, Cole Robinson wrote:
Currently it is visually at the same indent as <seclabel>. This fixes it to be grouped it with <devices>
Signed-off-by: Cole Robinson <crobinso@redhat.com>
Fixes: d4abb7b45d48aba77c2464dbea95f02a43a60834
--- docs/formatdomain.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano
It was added in 6.4.0, not 5.1.0 Signed-off-by: Cole Robinson <crobinso@redhat.com> --- docs/formatdomain.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 37c65add4d..8fc08c5fd2 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -4444,7 +4444,7 @@ After creating/opening the tap device, an optional shell script (given in the ``path`` attribute of the ``<script>`` element) will be run. :since:`Since 0.2.1` Also, after detaching/closing the tap device, an optional shell script (given in the ``path`` attribute of the ``<downscript>`` element) will be run. -:since:`Since 5.1.0` These can be used to do whatever extra host network +:since:`Since 6.4.0` These can be used to do whatever extra host network integration is required. :: -- 2.28.0
On a Sunday in 2020, Cole Robinson wrote:
It was added in 6.4.0, not 5.1.0
Signed-off-by: Cole Robinson <crobinso@redhat.com>
Fixes: 61ba6f09b181ec8c1591dc1df8c3cd8e093ca67b Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano
--- docs/formatdomain.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
spicevmc is the most common <redirdev> usage. This adds an XML example for it. Signed-off-by: Cole Robinson <crobinso@redhat.com> --- docs/formatdomain.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 8fc08c5fd2..9316dab9cc 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -4066,6 +4066,7 @@ after 0.9.5 (KVM only)` : ... <devices> + <redirdev bus='usb' type='spicevmc'/> <redirdev bus='usb' type='tcp'> <source mode='connect' host='localhost' service='4000'/> <boot order='1'/> -- 2.28.0
On a Sunday in 2020, Cole Robinson wrote:
spicevmc is the most common <redirdev> usage. This adds an XML example for it.
Signed-off-by: Cole Robinson <crobinso@redhat.com> --- docs/formatdomain.rst | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano
participants (2)
-
Cole Robinson -
Ján Tomko