On Thu, Sep 03, 2009 at 06:44:59PM +0200, Matthias Bolte wrote:

Check the config status before requesting config subelements

* src/esx/esx_driver.c: add configStatus to the requested properties to check it in esxVI_GetVirtualMachineIdentity() * src/esx/esx_vi.[ch]: add esxVI_GetManagedEntityStatus() and use it in esxVI_GetVirtualMachineIdentity() * src/esx/esx_vi_types.[ch]: add VI type esxVI_ManagedEntityStatus

Looks fine, I just find weird to define status based on color code instead of some explicit semantic, but heh, it's VMWare internals ! +enum _esxVI_ManagedEntityStatus { + esxVI_ManagedEntityStatus_Undefined = 0, + esxVI_ManagedEntityStatus_Gray, + esxVI_ManagedEntityStatus_Green, + esxVI_ManagedEntityStatus_Yellow, + esxVI_ManagedEntityStatus_Red, +}; Applied and commited, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/