----- "Daniel P. Berrange" <berrange@redhat.com> wrote:

On Tue, Jul 21, 2009 at 01:12:05PM +0200, Miloslav Trma?? wrote:

...

--- src/qemu_driver.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 50 insertions(+), 1 deletions(-)

IIUC this should only be needed when starting a QEMU guest.

The 'cont' method is called from quite a few different contexts. So it might be nice to pass a flag down from qemudStartVMDaemon such that the passphrase handling is guarenteed to only be run during startup (qemudStartVMDaemon is also used for migrate and restore, so covers those scenarios OK) qemudStartVMDaemon is called during migration (and restore), but it does not sent "cont".

The only place where "cont" is sent where passphrase handling is not necessary is qemudDomainResume. In any case, the passphrase handling only does something if qemu prompts for a passphrase, it does not hurt anything in other cases - on the contrary, should something go wrong and qemu would prompt for a passphrase, this ensures libvirt either supplies a passphrase, or reports an error, instead of hanging. Mirek