[libvirt PATCH] ci: move sanity_checks after other stages

Be less hostile to developers and run the build jobs even if the dco-check failed. That way they can test their own "private" branches without a sign-off. Also specify empty `needs` for it, since it does not depend on any of the jobs in the container phase and can be run right away. Signed-off-by: Ján Tomko <jtomko@redhat.com> --- A failed build still runs DCO: https://gitlab.com/jano.tomko/libvirt/-/pipelines/171565689 and vice-versa: https://gitlab.com/jano.tomko/libvirt/-/pipelines/171582293 .gitlab-ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 702198ec8e..f97c96dd21 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -2,9 +2,9 @@ variables: GIT_DEPTH: 100 stages: - - sanity_checks - containers - builds + - sanity_checks .script_variables: &script_variables | export MAKEFLAGS="-j$(getconf _NPROCESSORS_ONLN)" @@ -481,6 +481,7 @@ potfile: # merge requests are submitted check-dco: stage: sanity_checks + needs: [] image: registry.gitlab.com/libvirt/libvirt-ci/check-dco:master script: - /check-dco -- 2.26.2

On Tue, Jul 28, 2020 at 01:42:02PM +0200, Ján Tomko wrote:
Be less hostile to developers and run the build jobs even if the dco-check failed. That way they can test their own "private" branches without a sign-off.
Also specify empty `needs` for it, since it does not depend on any of the jobs in the container phase and can be run right away.
Signed-off-by: Ján Tomko <jtomko@redhat.com> --- A failed build still runs DCO: https://gitlab.com/jano.tomko/libvirt/-/pipelines/171565689 and vice-versa: https://gitlab.com/jano.tomko/libvirt/-/pipelines/171582293
.gitlab-ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
participants (2)
-
Daniel P. Berrangé
-
Ján Tomko